Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogServer does not have a proper close method #24

Closed
lamr02n opened this issue Sep 25, 2024 · 1 comment · Fixed by #40
Closed

LogServer does not have a proper close method #24

lamr02n opened this issue Sep 25, 2024 · 1 comment · Fixed by #40
Assignees
@lamr02n
Labels
bug Something isn't working

Comments

@lamr02n
Copy link
Collaborator

lamr02n commented Sep 25, 2024

The LogServer currently could produce some unexpected behavior, since when closing we cannot be sure everything is shut down correctly.
@lamr02n lamr02n added the bug Something isn't working label Sep 25, 2024
@lamr02n lamr02n self-assigned this Sep 25, 2024
@lamr02n lamr02n mentioned this issue Sep 25, 2024
Merged
@lamr02n lamr02n mentioned this issue Oct 6, 2024
Merged
@lamr02n
Copy link
Collaborator Author

lamr02n commented Oct 6, 2024

This is no longer an issue since LogServer.open() uses finally to stop all threads with #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamr02n lamr02n

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add docstrings and fix closing of LogServer stefanDeveloper/heiDGAF
1 participant
@lamr02n