Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: editorhost / runloop.cpp #16

Open
AZSlow3 opened this issue Dec 5, 2019 · 0 comments
Open

Linux: editorhost / runloop.cpp #16

AZSlow3 opened this issue Dec 5, 2019 · 0 comments

Comments

@AZSlow3
Copy link

AZSlow3 commented Dec 5, 2019

I am sorry for the tone, but which n00b has written it?
There are all typical errors a person does when creating his first Linux event loop in life...

In RunLoop::select :

  • select(). nfds should be max(fd)+1, not just max(fd)
  • selecting for writeFDs make no sense here and produce busy looping

In RunLoop::start :

  • it make sense first evaluate timeout and then use it then other way around (hoping it will select something the first time, so will be evaluated after)

In TimerProcessor::handleTimersAndReturnNextFireTimeInMs :

  • if (timersToFire.empty ()) should be if(timers.empty()). If we had no ready timers, that does not mean we do not need timers at all.

I know that "lucky bugs combination" make VSTGUI somehow run inside current version. But has no-one notice it consumes 70% (in case of VSTGUI) up to 100% (with other GUI) one core with absolutely idle plug-in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant