Reduce the x86-specificity of the crate #36
Conversation
Currently a lot of things are gated on `cfg(target_arch = "x86")`, which is used to indicate systems with 32-bit words. Apply the following changes to make this less specific: * Replace x86-32 configuration with configuration based on `target_pointer_width`. * Where possible, replace `#[cfg]` with `cfg!` or eliminate the check, to increase the percentage of code that gets validated on any platform. * Remove some configuration that was unneeded, for the same reason. This includes things like `#[cfg(target_arch = "x86")]` on comparisons to `EXPONENT_MIN` or `EXPONENT_MAX`. The checks are only useful on 32-bit platforms, but this is a trivial compiler optimization so not much is gained by keeping the config. I have verified that the crate builds on armv7 targets (but have not tested). Fixes: stencillogic#26
|
Would something like |
|
Thank you for raising the PR. |
I don't quite understand the idea. What problem would it solve? Platform independent serialization / deserialization? |
|
I was thinking of making it simpler for cases like this: astro-float/astro-float-num/src/ops/consts/e.rs Lines 143 to 156 in dd15e90 The arrays contain the same data, the 32-bit version just has to be split in half. A helper function could accept a u64 array on either platform and just reinterpret as needed. I guess this might not be too useful outside of writing platform-agnostic tests? |
Yes, it makes sense. There are several functions like this in the crate marked with |
Currently a lot of things are gated on
cfg(target_arch = "x86"), which is used to indicate systems with 32-bit words. Apply the following changes to make this less specific:target_pointer_width.#[cfg]withcfg!or eliminate the check, to increase the percentage of code that gets validated on any platform.#[cfg(target_arch = "x86")]on comparisons toEXPONENT_MINorEXPONENT_MAX. The checks are only useful on 32-bit platforms, but this is a trivial compiler optimization when these values are the same asExponent::{MIN,MAX}so not much is gained by keeping the config.I have verified that the crate builds on armv7 targets (but have not tested).
Fixes: #26