Version 18.0.0-beta3 is out - feedback desired

[stephanstapel]

Hi everybody,
I have created new nuget packages, named 18.0.0-beta3. It would be really great if you could test this version. Especially the pdf generation.
Thanks a lot in advance!
Stephan

[LordPinhead]

Hi Stephan,

thanks for the update. I pulled the new version and made first tests with realworld invoices we had, I have the XML files save to test for diffs, and they are identically.
One thing I would add, BT-41 can be set "twice", I will check out the code next week and make a PR for it, because you either write PersonName or DepartmentName into DefinedTradeContact, not both. It´s a bit hard to understand from the documentation. SAP and Datev seem to refuse invoices because of it.

[stephanstapel]

BT-41:
https://doc.factoorsharp.com/#bt-41

Code:
BT-41:

ZUGFeRD-csharp/ZUGFeRD/InvoiceDescriptor23CIIWriter.cs

Line 1875 in 2abebbd

writer.WriteOptionalElementString("ram", "PersonName", contact.Name);

BT-41-0:

ZUGFeRD-csharp/ZUGFeRD/InvoiceDescriptor23CIIWriter.cs

Line 1876 in 2abebbd

writer.WriteOptionalElementString("ram", "DepartmentName", contact.OrgUnit);

[IsThatUniqueEnough]

@LordPinhead is probably referring to the new BRs CII-SR-465 and CII-SR-466.

[stephanstapel]

CII-SR-465:
https://github.com/ConnectingEurope/eInvoicing-EN16931/blob/2bd83fe6f5488f9496e6b51d3022dcf7029111f8/cii/schematron/abstract/EN16931-CII-syntax.sch#L386
https://github.com/ConnectingEurope/eInvoicing-EN16931/blob/bf3a7d8d7137bec0c90f35d0fad42e30128fa2fd/cii/xslt/EN16931-CII-validation.xslt#L8455

Clear text:
An invoice must not contain both a contact person name and a contact department name for the seller at the same time.
If both are present, this is invalid and results in a warning, because only one BT-41 element is allowed per invoice.

CII-SR-466:
https://github.com/ConnectingEurope/eInvoicing-EN16931/blob/2bd83fe6f5488f9496e6b51d3022dcf7029111f8/cii/schematron/abstract/EN16931-CII-syntax.sch#L387
https://github.com/ConnectingEurope/eInvoicing-EN16931/blob/bf3a7d8d7137bec0c90f35d0fad42e30128fa2fd/cii/xslt/EN16931-CII-validation.xslt#L8472

Clear text:
An invoice must not contain both a contact person name and a contact department name for the buyer at the same time.
If both are present, this is invalid and results in a warning, because only one BT-56 element is allowed per invoice.

[stephanstapel]

I propose not to cover this on library level. I'd rather update the property documentation and just inform developers on this matter this way.