Export the factory.factory struct #57
Closed
jacobmolby
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
There is no specific reason, I just tend to be quite conservative with exporting things to reduce the need to introduce any breaking changes. Making the |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, is there a specific reason for why the
factory
struct isn't exported by the package?I think there is a lot of valid use cases for having it exported.
For instance if you have a lot of mods that you need to apply to the factory in your tests, you could have a helper function return a modified factory instance with the mods applied.
This however isn't possible at the moment. Since the type is private, it leads to a lot duplicated code.
If this were to be changed it should probably considered as a breaking change. If you are already importing another package that has a Factory struct inside it, it would conflict.
Beta Was this translation helpful? Give feedback.
All reactions