Skip to content

Commit 19b12c0

Browse files
committed
fix(vertical-pod-autoscaler): Update secretName for the TLS cert mount
When a custom issuer is used, the secret name and issuer name are no longer guaranteed to align. Signed-off-by: Alex Hamlin <[email protected]>
1 parent 86d2e43 commit 19b12c0

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

charts/vertical-pod-autoscaler/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@
1414

1515
## [UNRELEASED]
1616

17+
## [v1.8.1] - 2025-03-10
18+
19+
### Fixed
20+
21+
- Fixed the name of the secret mounted for TLS certificates when using a custom Issuer with cert-manager. ([#1140](https://github.com/stevehipwell/helm-charts/issues/1140)) _@ahamlinman_
22+
1723
## [v1.8.0] - 2025-02-14
1824

1925
### Added
@@ -126,6 +132,7 @@
126132
RELEASE LINKS
127133
-->
128134
[UNRELEASED]: https://github.com/stevehipwell/helm-charts/tree/main/charts/vertical-pod-autoscaler
135+
[v1.8.1]: https://github.com/stevehipwell/helm-charts/releases/tag/vertical-pod-autoscaler-1.8.1
129136
[v1.8.0]: https://github.com/stevehipwell/helm-charts/releases/tag/vertical-pod-autoscaler-1.8.0
130137
[v1.7.3]: https://github.com/stevehipwell/helm-charts/releases/tag/vertical-pod-autoscaler-1.7.3
131138
[v1.7.2]: https://github.com/stevehipwell/helm-charts/releases/tag/vertical-pod-autoscaler-1.7.2

charts/vertical-pod-autoscaler/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: vertical-pod-autoscaler
33
description: Helm chart for the Vertical Pod Autoscaler.
44
type: application
5-
version: 1.8.0
5+
version: 1.8.1
66
appVersion: 1.3.0
77
keywords:
88
- kubernetes

charts/vertical-pod-autoscaler/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# vertical-pod-autoscaler
22

3-
![Version: 1.8.0](https://img.shields.io/badge/Version-1.8.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.3.0](https://img.shields.io/badge/AppVersion-1.3.0-informational?style=flat-square)
3+
![Version: 1.8.1](https://img.shields.io/badge/Version-1.8.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.3.0](https://img.shields.io/badge/AppVersion-1.3.0-informational?style=flat-square)
44

55
The [Vertical Pod Autoscaler](https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/) (VPA) frees the users from necessity of setting up-to-date resource limits and requests for the containers in their pods. When configured, it will set the requests automatically based on usage and thus allow proper scheduling onto nodes so that appropriate resource amount is available for each pod. It will also maintain ratios between limits and requests that were specified in initial containers configuration.
66

@@ -33,15 +33,15 @@ This chart manages the `MutatingWebhookConfiguration` outside of the workload so
3333
To install the chart using the recommended OCI method you can use the following command.
3434

3535
```shell
36-
helm upgrade --install vertical-pod-autoscaler oci://ghcr.io/stevehipwell/helm-charts/vertical-pod-autoscaler --version 1.8.0
36+
helm upgrade --install vertical-pod-autoscaler oci://ghcr.io/stevehipwell/helm-charts/vertical-pod-autoscaler --version 1.8.1
3737
```
3838

3939
#### Verification
4040

4141
As the OCI chart release is signed by [Cosign](https://github.com/sigstore/cosign) you can verify the chart before installing it by running the following command.
4242

4343
```shell
44-
cosign verify --certificate-oidc-issuer https://token.actions.githubusercontent.com --certificate-identity-regexp 'https://github\.com/action-stars/helm-workflows/\.github/workflows/release\.yaml@.+' --certificate-github-workflow-repository stevehipwell/helm-charts --certificate-github-workflow-name Release ghcr.io/stevehipwell/helm-charts/vertical-pod-autoscaler:1.8.0
44+
cosign verify --certificate-oidc-issuer https://token.actions.githubusercontent.com --certificate-identity-regexp 'https://github\.com/action-stars/helm-workflows/\.github/workflows/release\.yaml@.+' --certificate-github-workflow-repository stevehipwell/helm-charts --certificate-github-workflow-name Release ghcr.io/stevehipwell/helm-charts/vertical-pod-autoscaler:1.8.1
4545
```
4646

4747
### Non-OCI Repository
@@ -50,7 +50,7 @@ Alternatively you can use the legacy non-OCI method via the following commands.
5050

5151
```shell
5252
helm repo add stevehipwell https://stevehipwell.github.io/helm-charts/
53-
helm upgrade --install vertical-pod-autoscaler stevehipwell/vertical-pod-autoscaler --version 1.8.0
53+
helm upgrade --install vertical-pod-autoscaler stevehipwell/vertical-pod-autoscaler --version 1.8.1
5454
```
5555

5656
## Values

charts/vertical-pod-autoscaler/templates/admission-controller/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ spec:
9191
volumes:
9292
- name: tls-certs
9393
secret:
94-
secretName: {{ include "vertical-pod-autoscaler.admissionController.webhookCertIssuerName" . }}
94+
secretName: {{ include "vertical-pod-autoscaler.admissionController.webhookCertSecret" . }}
9595
{{- with .Values.admissionController.nodeSelector }}
9696
nodeSelector:
9797
{{- toYaml . | nindent 8 }}

0 commit comments

Comments
 (0)