Update RSpec setup and gitignores

Author: stevenharman

.gitignore

@@ -1,14 +1,19 @@
-*.gem
-.bundle
-.ruby-version
-Gemfile.lock
-coverage
-bin/rspec
-bin/rake
-doc/
-lib/bundler/man
-/git-tracker
-pkg
-rdoc
-tmp
-tags
+# Ignore all log/temp/etc... files
+/log/
+/tmp/
+/tags
+
+# Package and dependency caches
+/.ruby-version
+/.bundle
+/Gemfile.lock
+/pkg/
+
+# Generated documentation
+/.yardoc
+/_yardoc/
+
+# Spec reports and failure tracking
+/coverage/
+/spec/rspec-status.txt
+/spec/reports/

.rspec

@@ -1,3 +1,2 @@
 --colour
--I spec/support
--r pry
+--require spec_helper

bin/rake

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rake' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rake", "rake")

bin/rspec

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

git_tracker.gemspec

@@ -25,17 +25,17 @@ Gem::Specification.new do |spec|
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path("..", __FILE__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(\.gitignore|\.rspec|\.travis\.yml|bin/|spec/|features/)}) }
   end
   spec.bindir = "exe"
   spec.executables = %w[git-tracker]
   spec.require_paths = ["lib"]
   spec.platform = Gem::Platform::RUBY
 
   spec.add_development_dependency "activesupport", "~> 6.0"
-  spec.add_development_dependency "pry", "~> 0.12"
-  spec.add_development_dependency "rake", "~> 12.0"
-  spec.add_development_dependency "rspec", "~> 3.8"
+  spec.add_development_dependency "pry-byebug", "~> 3.9"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.9"
   # Simplecov 0.18+ is currently broken for the cc-test-reporter.
   # Until it's fixed, we need to stick to something pre-0.18
   # see: https://github.com/codeclimate/test-reporter/issues/413

spec/git_tracker/branch_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "git_tracker/branch"
 
-describe GitTracker::Branch do
+RSpec.describe GitTracker::Branch do
   subject(:branch) { described_class }
 
   def stub_branch(ref, exit_status = 0)

spec/git_tracker/commit_message_spec.rb

@@ -1,8 +1,7 @@
-require "spec_helper"
 require "git_tracker/commit_message"
 require "active_support/core_ext/string/strip"
 
-describe GitTracker::CommitMessage do
+RSpec.describe GitTracker::CommitMessage do
   include CommitMessageHelper
 
   subject(:commit_message) { described_class.new(file) }

spec/git_tracker/hook_spec.rb

@@ -1,8 +1,7 @@
-require "spec_helper"
 require "git_tracker/hook"
 require "active_support/core_ext/string/strip"
 
-describe GitTracker::Hook do
+RSpec.describe GitTracker::Hook do
   subject(:hook) { described_class }
   let(:root) { "/path/to/git/repo/toplevel" }
   let(:hook_path) { File.join(root, ".git", "hooks", "prepare-commit-msg") }

spec/git_tracker/prepare_commit_message_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "git_tracker/prepare_commit_message"
 
-describe GitTracker::PrepareCommitMessage do
+RSpec.describe GitTracker::PrepareCommitMessage do
   subject(:prepare_commit_message) { GitTracker::PrepareCommitMessage }
 
   describe ".run" do

spec/git_tracker/repository_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "git_tracker/repository"
 
-describe GitTracker::Repository do
+RSpec.describe GitTracker::Repository do
   subject(:repository) { described_class }
   let(:git_command) { "git rev-parse --show-toplevel" }
   before do

spec/git_tracker/runner_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "git_tracker/runner"
 
-describe GitTracker::Runner do
+RSpec.describe GitTracker::Runner do
   subject(:runner) { described_class }
   let(:args) { ["a_file", "the_source", "sha1234"] }
 

spec/git_tracker/standalone_spec.rb

@@ -1,6 +1,6 @@
 require "git_tracker/standalone"
 
-describe GitTracker::Standalone do
+RSpec.describe GitTracker::Standalone do
   describe "#save" do
     before do
       File.delete "git-tracker" if File.exist? "git-tracker"

spec/spec_helper.rb

@@ -3,12 +3,46 @@
   SimpleCov.start
 end
 
+require "pry-byebug"
 require_relative "support/commit_message_helper"
 require_relative "support/fake_file"
 require_relative "support/output_helper"
 require_relative "support/matchers/exit_code_matchers"
 
 RSpec.configure do |config|
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+  config.filter_run_when_matching :focus
+  config.example_status_persistence_file_path = "spec/rspec-status.txt"
+  config.disable_monkey_patching!
+  config.warnings = true
+
+  if config.files_to_run.one?
+    config.default_formatter = "doc"
+  end
+  # config.profile_examples = 10
+  config.order = :random
+  Kernel.srand(config.seed)
 end