[Android] Touch problem #1236
Open
[Android] Touch problem #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianwesty
changed the title
ComiR
reviewed
Mar 18, 2019
| // watch only for left mouse, touch contact and pen contact | ||
| // touchstart event object doesn`t have button property | ||
| if (e.type !== 'touchstart' && e.button !== 0) { | ||
| if ((e.type !== 'touchstart' || e.type !== 'pointerdown') && e.button !== 0) { |
There was a problem hiding this comment.
This change doesn't make any sense.
Your proposed (e.type !== 'touchstart' || e.type !== 'pointerdown') could also be written as !(e.type === 'touchstart' && e.type === 'pointerdown'). As you probably can see now, this would always be true,...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, tap on an image in the carousel.
Next and previous icons are highlighted but images cannot move by drag or via next/previous links.