-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All unit tests must pass in strict mode #891
Comments
All passing except for this one case that we're still debating. |
@rikkarth No worries, I will go ahead and accept this PR and merge it in 3 days. Will also hold off on merging #894 so that you don't have yet another commit to merge to. This must be deleted or at least commented out. You can do it yourself if you have time, or I can edit the file in place. |
I will clean it up for you. Thank you @stleary If you have some tests that need optimization, review or implementation let me know I can help in doing some. |
Merged. |
The unit tests should yield the same result for default and strict mode parsing.
Tests may fail for the following reasons:
The unit tests will be updated as a separate issue from #887 and #888. After merging the unit test fixes, the review of strict mode may continue.
The text was updated successfully, but these errors were encountered: