Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONArray has a bug when calling addAll with a collection (infinite recursion) #901

Open
jacob-wieland-gematik opened this issue Jul 15, 2024 · 3 comments
Open

JSONArray has a bug when calling addAll with a collection (infinite recursion) #901

jacob-wieland-gematik opened this issue Jul 15, 2024 · 3 comments

Comments

@jacob-wieland-gematik
Copy link

jacob-wieland-gematik commented Jul 15, 2024 •
edited
Loading

In Line 1913, the jsonParserConfiguration needs to be passed as last argument
@stleary
Copy link
Owner

stleary commented Jul 15, 2024

@jacob-wieland-gematik Can you provide an example of this bug?
What version are you using? The referenced line number, 1913, does not match the latest JSONArray code.

@hexetia
Copy link

hexetia commented Oct 5, 2024 •
edited
Loading

I found this problem yesterday while upgrading from version 20231013 to 20240205.
In PR #823 a regression was introduced with the addition of more parameters to the function addAll, the call to it on addAll from collection did not contemplate the inclusion of all the new parameters and will cause a stackoverflow error when calling the JsonArray.putAll with a list casted as Object
image

hexetia added a commit to hexetia/JSON-java that referenced this issue Oct 5, 2024
@hexetia
test(stleary#901): call JsonArray.putAll with a casted list as object
0d71dcf
hexetia added a commit to hexetia/JSON-java that referenced this issue Oct 5, 2024
@hexetia
fix(stleary#901): add the jsonparserConfiguration param to avoid a st…
14e9cdc 
…ackoverflow error
@hexetia hexetia mentioned this issue Oct 5, 2024
Open
@stleary
Copy link
Owner

stleary commented Oct 5, 2024

@hexetia Thanks for the info and analysis. Will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hexetia @stleary @jacob-wieland-gematik