Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenient http-spec #30

Open
4 tasks
P0lip opened this issue Oct 16, 2019 · 3 comments
Open
4 tasks

Lenient http-spec #30

P0lip opened this issue Oct 16, 2019 · 3 comments

Comments

@P0lip
Copy link
Contributor

P0lip commented Oct 16, 2019

Chore summary
The low-level goal is to make http-spec treat malformed input in a more graceful manner.
The high-level goal is to improve UX in Studio, in particular when you open an existing spec that's incorrect.

Tasks

  • upgrade to TS 3.7
  • use Optional<DeepPartial<actual shape>> whenever possible
  • drop all calls clobbering typings such as lodash.get and use optional chaining operator
  • add a couple of tests covering edge cases

Additional context
Prettier uses outdated typescript/es-tree parser and won't parse optional chaining operator correctly.
For the time being, suggest turning off prettier rule in TSLint config until they upgrade it.

@P0lip
Copy link
Contributor Author

P0lip commented Oct 16, 2019

Optional<DeepPartial<actual shape>> might be look tad controversial, therefore if you all think it's an overkill, we can stick with DeepPartial<actual shape>.

@chohmann
Copy link
Contributor

@P0lip is this issue still relevant?

@P0lip
Copy link
Contributor Author

P0lip commented Nov 30, 2020

Yeah, it's still relevant.
The situation has improved over the time, but there is still plenty to be done.
FWIW, Vincenzo has context on this one, as we used to rant chat about it in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants