-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit scope of global styles / reset #143
Comments
@Fox32 no rush but whenever you have a moment could you expand a bit re how you're integrating JSV (and thus mosaic) into your application? Curious to learn a bit more about your use case to help inform decision making here. Oh also a few examples re which bits of the global CSS are causing you the most issue would be helpful as well to get an idea of the potential problems! |
Good news, it's all open source. The plan is to integrate it as a viewer for json schemas in the api-docs plugin of Backstage. I created the following PR: backstage/backstage#5532 (now reverted, but I'm happy to reland it later). As I'm using mosaic only for the viewer I only need the styles locally. However, as you already mentioned above, this is an issue with popovers, like the select box. Maybe it would also be an option to provide it as a web component which might provide better style isolation. |
any news on this ? i really dont want to include the whole mosaic styles only for this |
related to stoplightio/elements#2250 |
Moving #115 (comment) over here.
Global css reset might cause issues in consuming applications - what are our options?
--
Separate the reset css out to separate file / functions that end user would be expected to include themselves if they are not using their own reset.
Downsides are:
Option to customize reset scope somehow. This is tricky because:
The text was updated successfully, but these errors were encountered: