Skip to content

Commit f56c7b0

Browse files
v3.5.0-beta.1...v3.20.2
1 parent ec5587c commit f56c7b0

22 files changed

+263
-108
lines changed

.editorconfig

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
root = true
66

7-
87
[*]
98
end_of_line = lf
109
charset = utf-8

.eslintignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
/tmp/
88

99
# dependencies
10-
/bower_components/
10+
/node_modules/
1111

1212
# misc
1313
/coverage/
14+
!.*
1415

1516
# ember-try
1617
/.node_modules.ember-try/
17-
/bower.json.ember-try
1818
/package.json.ember-try

.eslintrc.js

+37-4
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,48 @@
11
module.exports = {
22
root: true,
3+
parser: 'babel-eslint',
34
parserOptions: {
4-
ecmaVersion: 2017,
5-
sourceType: 'module'
5+
ecmaVersion: 2018,
6+
sourceType: 'module',
7+
ecmaFeatures: {
8+
legacyDecorators: true
9+
}
610
},
711
extends: 'eslint:recommended',
812
env: {
913
browser: true,
1014
node: true,
1115
mocha: true
1216
},
13-
rules: {
14-
}
17+
rules: {},
18+
overrides: [
19+
// node files
20+
{
21+
files: [
22+
'.eslintrc.js',
23+
'.template-lintrc.js',
24+
'ember-cli-build.js',
25+
'index.js',
26+
'testem.js',
27+
'blueprints/*/index.js',
28+
'config/**/*.js',
29+
'tests/dummy/config/**/*.js'
30+
],
31+
excludedFiles: [
32+
'addon/**',
33+
'addon-test-support/**',
34+
'app/**',
35+
'tests/dummy/app/**'
36+
],
37+
parserOptions: {
38+
sourceType: 'script'
39+
},
40+
env: {
41+
browser: false,
42+
node: true
43+
},
44+
plugins: ['node'],
45+
extends: ['plugin:node/recommended']
46+
}
47+
]
1548
};

.gitignore

+6-2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,15 @@
55
/tmp/
66

77
# dependencies
8-
/bower_components/
98
/node_modules/
109

10+
# storybook
11+
/storybook-static/
12+
/.storybook/preview-head.html
13+
1114
# misc
15+
/.env*
16+
/.pnp*
1217
/.sass-cache
1318
/connect.lock
1419
/coverage/
@@ -19,7 +24,6 @@
1924

2025
# ember-try
2126
/.node_modules.ember-try/
22-
/bower.json.ember-try
2327
/package.json.ember-try
2428
package-lock.json
2529
yarn.lock

.npmignore

+5-7
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,19 @@
22
/dist/
33
/tmp/
44

5-
# dependencies
6-
/bower_components/
7-
85
# misc
9-
/.bowerrc
106
/.editorconfig
117
/.ember-cli
8+
/.env*
129
/.eslintignore
1310
/.eslintrc.js
11+
/.git/
1412
/.gitignore
15-
/.watchmanconfig
13+
/.template-lintrc.js
1614
/.travis.yml
17-
/bower.json
15+
/.watchmanconfig
1816
/config/ember-try.js
17+
/CONTRIBUTING.md
1918
/ember-cli-build.js
2019
/testem.js
2120
/tests/
@@ -24,5 +23,4 @@
2423

2524
# ember-try
2625
/.node_modules.ember-try/
27-
/bower.json.ember-try
2826
/package.json.ember-try

.template-lintrc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
extends: 'recommended'
4+
extends: 'octane'
55
};

.travis.yml

+13-15
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ language: node_js
33
node_js:
44
# we recommend testing addons with the same minimum supported node version as Ember CLI
55
# so that your addon works for all apps
6-
- "6"
6+
- "10"
77

8-
sudo: false
9-
dist: trusty
8+
dist: xenial
109

1110
addons:
1211
chrome: stable
@@ -20,35 +19,34 @@ env:
2019
# See https://git.io/vdao3 for details.
2120
- JOBS=1
2221

22+
branches:
23+
only:
24+
- master
25+
# npm version tags
26+
- /^v\d+\.\d+\.\d+/
27+
2328
jobs:
24-
fail_fast: true
29+
fast_finish: true
2530
allow_failures:
2631
- env: EMBER_TRY_SCENARIO=ember-canary
2732

2833
include:
2934
# runs linting and tests with current locked deps
30-
3135
- stage: "Tests"
3236
name: "Tests"
3337
script:
34-
- npm run lint:hbs
35-
- npm run lint:js
38+
- npm lint
3639
- npm test
3740

3841
# we recommend new addons test the current and previous LTS
3942
# as well as latest stable release (bonus points to beta/canary)
40-
- stage: "Additional Tests"
41-
env: EMBER_TRY_SCENARIO=ember-lts-2.16
42-
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
43+
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
44+
- env: EMBER_TRY_SCENARIO=ember-lts-3.20
4345
- env: EMBER_TRY_SCENARIO=ember-release
4446
- env: EMBER_TRY_SCENARIO=ember-beta
4547
- env: EMBER_TRY_SCENARIO=ember-canary
4648
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
47-
48-
before_install:
49-
- npm config set spin false
50-
- npm install -g npm@4
51-
- npm --version
49+
- env: EMBER_TRY_SCENARIO=ember-classic
5250

5351
script:
5452
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

CONTRIBUTING.md

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# How To Contribute
2+
3+
## Installation
4+
5+
* `git clone <repository-url>`
6+
* `cd @storybook/ember-cli-storybook`
7+
* `yarn install`
8+
9+
## Linting
10+
11+
* `yarn lint:hbs`
12+
* `yarn lint:js`
13+
* `yarn lint:js --fix`
14+
15+
## Running tests
16+
17+
* `ember test` – Runs the test suite on the current Ember version
18+
* `ember test --server` – Runs the test suite in "watch mode"
19+
* `ember try:each` – Runs the test suite against multiple Ember versions
20+
21+
## Running the dummy application
22+
23+
* `ember serve`
24+
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
25+
26+
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

README.md

+11
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,15 @@ ember-cli-storybook
33

44
📒 Ember storybook adapter
55

6+
7+
Compatibility
8+
------------------------------------------------------------------------------
9+
10+
* Ember.js v3.16 or above
11+
* Ember CLI v2.13 or above
12+
* Node.js v10 or above
13+
14+
615
Installation
716
------------------------------------------------------------------------------
817

@@ -173,6 +182,8 @@ export let Standard = () => {
173182
};
174183
```
175184

185+
See the [Contributing](CONTRIBUTING.md) guide for details.
186+
176187
License
177188
------------------------------------------------------------------------------
178189

config/ember-try.js

+79
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
'use strict';
2+
3+
const getChannelURL = require('ember-source-channel-url');
4+
5+
module.exports = async function() {
6+
return {
7+
useYarn: true,
8+
scenarios: [
9+
{
10+
name: 'ember-lts-3.16',
11+
npm: {
12+
devDependencies: {
13+
'ember-source': '~3.16.0'
14+
}
15+
}
16+
},
17+
{
18+
name: 'ember-lts-3.20',
19+
npm: {
20+
devDependencies: {
21+
'ember-source': '~3.20.5'
22+
}
23+
}
24+
},
25+
{
26+
name: 'ember-release',
27+
npm: {
28+
devDependencies: {
29+
'ember-source': await getChannelURL('release')
30+
}
31+
}
32+
},
33+
{
34+
name: 'ember-beta',
35+
npm: {
36+
devDependencies: {
37+
'ember-source': await getChannelURL('beta')
38+
}
39+
}
40+
},
41+
{
42+
name: 'ember-canary',
43+
npm: {
44+
devDependencies: {
45+
'ember-source': await getChannelURL('canary')
46+
}
47+
}
48+
},
49+
{
50+
name: 'ember-default-with-jquery',
51+
env: {
52+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
53+
'jquery-integration': true
54+
})
55+
},
56+
npm: {
57+
devDependencies: {
58+
'@ember/jquery': '^1.1.0'
59+
}
60+
}
61+
},
62+
{
63+
name: 'ember-classic',
64+
env: {
65+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
66+
'application-template-wrapper': true,
67+
'default-async-observers': false,
68+
'template-only-glimmer-components': false
69+
})
70+
},
71+
npm: {
72+
ember: {
73+
edition: 'classic'
74+
}
75+
}
76+
}
77+
]
78+
};
79+
};

index.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const mergeTrees = require('broccoli-merge-trees');
88
const { parse, generatePreviewHead } = require('./util');
99

1010
module.exports = {
11-
name: 'ember-cli-storybook',
11+
name: require('./package').name,
1212

1313
_getOptions() {
1414
let addonOptions = (this.parent && this.parent.options) || (this.app && this.app.options) || {};
@@ -70,6 +70,7 @@ module.exports = {
7070
const distFilePath = path.resolve(result.directory, 'index.html');
7171
const testFilePath = path.resolve(result.directory, 'tests/index.html');
7272
const previewHeadFilePath = path.resolve(process.cwd(), '.storybook/preview-head.html');
73+
const previewHeadDirectory = path.dirname(previewHeadFilePath);
7374
const envFilePath = path.resolve(process.cwd(), '.env');
7475

7576
let fileContents = '';
@@ -94,7 +95,8 @@ module.exports = {
9495

9596
this.ui.writeLine('Generating files needed by Storybook');
9697

97-
fs.writeFileSync(previewHeadFilePath, previewHead)
98+
fs.mkdirSync(previewHeadDirectory, { recursive: true });
99+
fs.writeFileSync(previewHeadFilePath, previewHead);
98100

99101
this.ui.writeLine('Generating .env');
100102

0 commit comments

Comments
 (0)