Skip to content

Commit 2dddf72

Browse files
revert: remove unnecessary to_checksum_address in register when IP already registered
1 parent 00664d8 commit 2dddf72

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/story_protocol_python_sdk/resources/IPAsset.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,6 @@ def register(
200200
try:
201201
ip_id = self._get_ip_id(nft_contract, token_id)
202202
if self.is_registered(ip_id):
203-
# Ensure ip_id is in checksum format when returning
204-
ip_id = self.web3.to_checksum_address(ip_id)
205203
return {"tx_hash": None, "ip_id": ip_id}
206204

207205
req_object: dict = {

tests/unit/resources/test_ip_asset.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,7 @@ def test_register_already_registered(
156156
):
157157
with mock_get_ip_id(), mock_is_registered(True):
158158
response = ip_asset.register(ADDRESS, 3)
159-
# IP_ID will be converted to checksum format in register method
160-
expected_ip_id = ip_asset.web3.to_checksum_address(IP_ID)
161-
assert response["ip_id"] == expected_ip_id
159+
assert response["ip_id"] == IP_ID
162160
assert response["tx_hash"] is None
163161

164162
def test_register_successful(

0 commit comments

Comments
 (0)