-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(deps) upgrade to msgspec>=0.19.0 to fix py313@macos #3764
(deps) upgrade to msgspec>=0.19.0 to fix py313@macos #3764
Conversation
Reviewer's Guide by SourceryThis pull request upgrades the msgspec dependency to version 0.19.0 or higher to address a bug that causes installation failures on MacOS with Python 3.13. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alexey-pelykh - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only bumping the poetry.lock
, it won't affect the release version, so I would say that we don't need a release in here, as it will only affect dev
0c1d9d8
to
e8ae162
Compare
@bellini666 RELEASE.md removed |
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
Description
poetry install --with integrations
fails on MacOS with Python 3.13Types of Changes
Issues Fixed or Closed by This PR
N/A
Checklist
Summary by Sourcery
Upgrade msgspec to version >=0.19.0 to fix compatibility issues with Python 3.13 on MacOS.
Bug Fixes:
poetry install --with integrations
failed on MacOS with Python 3.13.Chores: