Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applyPatch in json-patch mutates patch Operations typed as readonly #813

Closed
atsjo opened this issue Jan 22, 2025 · 1 comment
Closed

applyPatch in json-patch mutates patch Operations typed as readonly #813

atsjo opened this issue Jan 22, 2025 · 1 comment

Comments

@atsjo
Copy link
Contributor

atsjo commented Jan 22, 2025

Since all my state is frozen I discovered this by an exception, and tracked it down to the "replace" operation. I can see deepClone is used for the "add" operation, and prepared a PR for a similar fix to the "replace" operation.

And thanx @streamich for a very powerful library! I have implemented json-patch with ot and string diff support, and made 2 PR's for the issues I found, as I can see you are very busy with json-crdt now...

@streamich
Copy link
Owner

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants