window `close` event does not get triggered anymore

[bastimeyer]

Checklist

• I understand that Streamlink Twitch GUI is just a launcher for Streamlink
• I have read the contribution guidelines
• I have checked the list of open and recently closed issues
• I have checked the commit log of the master branch

Streamlink Twitch GUI version

v2.2.0

Streamlink version

No response

Operating system, environment and configuration details

.

Description

Since the upgrade of NW.js from 0.64.1 to 0.68.1 in 3d641ad (part of the v2.2.0 release), the close event on the main application window doesn't get triggered anymore, and neither seem SIGTERM/SIGINT signal callbacks on the global process instance (not used in the application code). This means that the confirmation dialog won't be shown when trying to close the application while streams are still running.

streamlink-twitch-gui/src/app/init/instance-initializers/nwjs/instance-initializer.js

Lines 102 to 116 in 2d933e0

	// listen for the close event and show the dialog instead of strictly shutting down
	nwWindow.on( "close", function() {
	if ( location.pathname !== "/index.html" ) {
	nwWindow.close( true );
	return;
	}
	try {
	setVisibility( true );
	setFocused( true );
	nwjs.close();
	} catch ( e ) {
	quit();
	}
	});

I've already had a quick look at the issue, but this needs more debugging with a proper reproduction, so the issue can be reported upstream.

Debug log

No response

[bastimeyer]

nwjs/nw.js#7981