From 6744a537a8d2211beb68c238a52740326e0bb8fa Mon Sep 17 00:00:00 2001 From: Antonio Pedro Date: Tue, 23 Jul 2024 03:44:47 +0530 Subject: [PATCH] fix nits Signed-off-by: Antonio Pedro --- .../kafka/bridge/http/converter/HttpJsonMessageConverter.java | 4 ++-- src/test/java/io/strimzi/kafka/bridge/http/ProducerIT.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/io/strimzi/kafka/bridge/http/converter/HttpJsonMessageConverter.java b/src/main/java/io/strimzi/kafka/bridge/http/converter/HttpJsonMessageConverter.java index 589f2c2f..de0db8b3 100644 --- a/src/main/java/io/strimzi/kafka/bridge/http/converter/HttpJsonMessageConverter.java +++ b/src/main/java/io/strimzi/kafka/bridge/http/converter/HttpJsonMessageConverter.java @@ -75,7 +75,7 @@ public List> toKafkaRecords(String kafkaTopic, In JsonNode json = JsonUtils.bytesToJson(messages); ArrayNode jsonArray = (ArrayNode) json.get("records"); - for (JsonNode jsonObj : jsonArray) { + for (JsonNode jsonObj: jsonArray) { records.add(toKafkaRecord(kafkaTopic, partition, JsonUtils.jsonToBytes(jsonObj))); } return records; @@ -106,7 +106,7 @@ public byte[] toMessages(ConsumerRecords records) { ArrayNode headers = JsonUtils.createArrayNode(); - for (Header kafkaHeader : record.headers()) { + for (Header kafkaHeader: record.headers()) { ObjectNode header = JsonUtils.createObjectNode(); header.put("key", kafkaHeader.key()); diff --git a/src/test/java/io/strimzi/kafka/bridge/http/ProducerIT.java b/src/test/java/io/strimzi/kafka/bridge/http/ProducerIT.java index 7ececc1b..9d518bd9 100644 --- a/src/test/java/io/strimzi/kafka/bridge/http/ProducerIT.java +++ b/src/test/java/io/strimzi/kafka/bridge/http/ProducerIT.java @@ -107,6 +107,7 @@ void sendSimpleMessageToPartition(VertxTestContext context) throws InterruptedEx KafkaFuture future = adminClientFacade.createTopic(topic, 2, 1); String value = "message-value"; + int partition = 1; JsonArray records = new JsonArray(); @@ -208,7 +209,6 @@ void sendSimpleMessageWithKey(VertxTestContext context) throws InterruptedExcept KafkaFuture future = adminClientFacade.createTopic(topic, 2, 1); String value = "message-value"; - String key = "my-key"; JsonArray records = new JsonArray();