Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation request metric reported incorrectly #203

Open
nkostoulas opened this issue Sep 5, 2023 · 2 comments
Open

Validation request metric reported incorrectly #203

nkostoulas opened this issue Sep 5, 2023 · 2 comments

Comments

@nkostoulas
Copy link

nkostoulas commented Sep 5, 2023

I have enabled OAuth metrics on my strimzi broker cluster and I am exporting these to Prometheus using JMX.

I noticed that the strimzi_oauth_validation_requests_count seems to be incorrectly reported, as when I'm using a Kafka client to request Topic Metadata from the brokers and authenticating with OAuth, the counter metric seems to be incremented as both a success and a failure for each request.

strimzi_oauth_validation_requests_count{kind="jwks", error_type="other", outcome="error", ...} | 14

strimzi_oauth_validation_requests_count{kind="jwks", outcome="success", ...}  | 14

Am I missing something or is this a know issue? I assume this metric is incremented every time there is a client request to Kafka and an error should only be reported if the jwt token is invalid.

@nkostoulas
Copy link
Author

nkostoulas commented Sep 5, 2023

Oh this #177 might have fixed it. Why would an unsupported callback be called though when using Strimzi?

@mstruk
Copy link
Contributor

mstruk commented Sep 7, 2023

Sounds like the same issue, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants