Fix bug with checkbox list causing infinite re-renders when panel tog…

…gled
strudel-science · Aug 29, 2024 · 5f8fd33 · 5f8fd33
1 parent 193d94a
commit 5f8fd33
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/strudel-taskflows/src/components/CheckboxList.tsx b/strudel-taskflows/src/components/CheckboxList.tsx
@@ -39,8 +39,9 @@ export const CheckboxList: React.FC<CheckboxListProps> = ({
   };
 
   useEffect(() => {
-    console.log(checkValues)
-    if (onChange) onChange(checkValues);
+    if (onChange && checkValues?.length !== values?.length) {
+      onChange(checkValues);
+    }
   }, [checkValues]);
 
   useEffect(() => {

diff --git a/strudel-taskflows/src/components/FilterContext.tsx b/strudel-taskflows/src/components/FilterContext.tsx
@@ -43,15 +43,10 @@ function filterReducer(state: FilterState, action: FilterAction): FilterState {
       } else if (filter.value) {
         activeFilters.push(filter);
       }
-      console.log(activeFilters);
       return {
         ...state,
         activeFilters
       }
-      // return {
-      //   ...state,
-      //   activeFilters: { ...state.activeFilters, [action.payload.field]: action.payload.value }
-      // }
     }
     case 'SET_ACTIVE_FILTERS': {
       return {
@@ -95,14 +90,6 @@ export const FilterContext: React.FC<FilterContextProps> = ({
     if (onChange) onChange(state.activeFilters);
   }, [JSON.stringify(state.activeFilters)]);
 
-  /**
-   * If activeFilters is changed from outside the context (e.g. filters are reset)
-   * then the new value should be dispatched.
-   */
-  // useEffect(() => {
-  //   dispatch({ type: 'SET_ACTIVE_FILTERS', payload: activeFilters });
-  // }, [activeFilters]);
-
   return (
     <FilterContextAPI.Provider value={value}>
       {children}

diff --git a/strudel-taskflows/src/pages/explore-data/index.tsx b/strudel-taskflows/src/pages/explore-data/index.tsx
@@ -1,4 +1,4 @@
-import { Box, Grid, Paper, Stack } from '@mui/material';
+import { Box, Paper, Stack } from '@mui/material';
 import React, { useState } from 'react';
 import { FilterContext } from '../../components/FilterContext';
 import { PageHeader } from '../../components/PageHeader';