[Bugfix] Performance: scroll layout thrashing #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating the scroll serviced props, we read values from the DOM which trigger a layout recalculation too soon. We switch to using the existing `domScheduler` to separate updating the props and triggering the service's callbacks into different scheduled tasks.
Reading the scroll from the window can trigger layout thrashing, switching to scroll values from the scroll service which already implement a more performant way of reading scroll values.
Export Size@studiometa/js-toolkit
Unchanged@studiometa/js-toolkit
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## develop #645 +/- ##
========================================
Coverage 99.13% 99.13%
========================================
Files 122 122
Lines 4186 4186
Branches 1139 1143 +4
========================================
Hits 4150 4150
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
No
β Type of change
π Description
The
useSroll()service and thewithScrolledInViewdecorator were reading the current scroll from thewindowobject on each frame, triggering layout thrashing and slowing performance down.This PR refactors access to the current scroll to limit performance drains.
π Checklist