Skip to content

Make format check pipeline only react on diff'd files #128

@mortbopet

Description

@mortbopet
Contributor

Currently, the format check pipeline will check the entire repo for out-of-format files. This is an issue for PRs which may have failing format PR gates without having touched other files in the repo, if those files somehow have drifted away from the accepted format.

For clang-format, i would recommend to borrow/steal the steps here which runs clang-format on the git diff, and prints/uploads patches.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mortbopet

        Issue actions

          Make format check pipeline only react on diff'd files · Issue #128 · substrait-io/substrait-cpp