Skip to content

thumb service: should required params actually be part of routes? #62

Open
@ndushay

Description

@ndushay

Given that the routes are:

[was@was-thumbnail-prod current]$ bundle exec rake routes RAILS_ENV=production
          Prefix Verb URI Pattern                                         Controller#Action
      okcomputer      /status                                             OkComputer::Engine
            root GET  /                                                   admin#seeds
      jobs_retry GET  /jobs/retry(.:format)                               jobs#retry
     jobs_remove GET  /jobs/remove(.:format)                              jobs#remove
      admin_jobs GET  /admin/jobs(.:format)                               admin#jobs
     admin_seeds GET  /admin/seeds(.:format)                              admin#seeds
    admin_errors GET  /admin/errors(.:format)                             admin#errors
admin_thumbnails GET  /admin/thumbnails(.:format)                         admin#thumbnails
   api_seed_list GET  /api/seed/list(.:format)                            api/seed#list
 api_seed_create GET  /api/seed/create(.:format)                          api/seed#create
                 GET  /api/v1/was/thumbnails/druid_id/:druid_id(.:format) api/thumbnails#list
                 GET  /api/v1/was/thumbnails/uri(.:format)                api/thumbnails#list

note that the /jobs routes and the admin/thumbnail/ require a parameter ... should it just be part of the route? (there may be other candidates, too)

e.g. admin/thumbnail/:druid vs admin/thumbnail?druid=xxx

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions