-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Before we enable ORCID harvesting, we should do two things:
-
Verify the contribution records being created for both newly harvested publication and for existing publications (ie. in the database but need to be linked to a new author), both have valid publication_ids. See NoMethodError: undefined method `id' for nil:NilClass #1477 and prevent bad data from being created in contributions #1482
-
Verify that citation generation works
There appears to be some custom mapping of names that used to create the formatted citations (APA, Chicago, MLA) that are added to the pub_hash, that is dependent on the data source (e.g. Pubmed vs WoS). We should ensure this works for ORCID sourced publications before turning on ORCID harvesting.
For example, see https://github.com/sul-dlss/sul_pub/blob/main/lib/csl/role_mapper.rb#L12-L31
This code uses the provenance to call different classes depending on the source. We need to sort out what happens for ORCID sourced publications, or else there may be issue generating a citation for these publications (unless the implicit fallback to this general method for mapping citation names works fine: https://github.com/sul-dlss/sul_pub/blob/main/lib/csl/role_mapper.rb#L54-L71)