[FIX] mass_merge_lite: bug in act_window

ntsirintanis · ntsirintanis · commit 26be8b673863 · 2024-11-27T09:37:57.000+01:00
diff --git a/mass_merge_lite/models/record_merge_id.py b/mass_merge_lite/models/record_merge_id.py
@@ -755,14 +755,14 @@ def view_relation_object(self):
             if not self.criteria_ids:
                 raise ValidationError(_("There are no criteria associated"))
             else:
-                action = self.env["ir.actions.act_window"].for_xml_id(
-                    "record_merge", "record_merge_criteria_act_window"
+                action = self.env.ref(
+                    "mass_merge_lite.record_merge_criteria_act_window"
                 )
+                action = action.read([])[0]
                 action.update(
                     {
                         "res_id": self.criteria_ids.id,
                         "views": [(False, "form")],
-                        "view_type": "form",
                         "view_mode": "form",
                     }
                 )
@@ -772,14 +772,12 @@ def view_relation_object(self):
             if not self.merge_ids:
                 raise ValidationError(_("There are no merges associated"))
             else:
-                action = self.env["ir.actions.act_window"].for_xml_id(
-                    "record_merge", "record_merge_id_act_window"
-                )
+                action = self.env.ref("mass_merge_lite.record_merge_id_act_window")
+                action = action.read([])[0]
                 action.update(
                     {
                         "res_id": self.merge_ids.id,
                         "views": [(False, "form")],
-                        "view_type": "form",
                         "view_mode": "form",
                     }
                 )

Original file line number	Diff line number	Diff line change
`@@ -755,14 +755,14 @@ def view_relation_object(self):`
`755`	`755`	`if not self.criteria_ids:`
`756`	`756`	`raise ValidationError(_("There are no criteria associated"))`
`757`	`757`	`else:`
`758`		`- action = self.env["ir.actions.act_window"].for_xml_id(`
`759`		`- "record_merge", "record_merge_criteria_act_window"`
	`758`	`+ action = self.env.ref(`
	`759`	`+ "mass_merge_lite.record_merge_criteria_act_window"`
`760`	`760`	`)`
	`761`	`+ action = action.read([])[0]`
`761`	`762`	`action.update(`
`762`	`763`	`{`
`763`	`764`	`"res_id": self.criteria_ids.id,`
`764`	`765`	`"views": [(False, "form")],`
`765`		`- "view_type": "form",`
`766`	`766`	`"view_mode": "form",`
`767`	`767`	`}`
`768`	`768`	`)`
`@@ -772,14 +772,12 @@ def view_relation_object(self):`
`772`	`772`	`if not self.merge_ids:`
`773`	`773`	`raise ValidationError(_("There are no merges associated"))`
`774`	`774`	`else:`
`775`		`- action = self.env["ir.actions.act_window"].for_xml_id(`
`776`		`- "record_merge", "record_merge_id_act_window"`
`777`		`- )`
	`775`	`+ action = self.env.ref("mass_merge_lite.record_merge_id_act_window")`
	`776`	`+ action = action.read([])[0]`
`778`	`777`	`action.update(`
`779`	`778`	`{`
`780`	`779`	`"res_id": self.merge_ids.id,`
`781`	`780`	`"views": [(False, "form")],`
`782`		`- "view_type": "form",`
`783`	`781`	`"view_mode": "form",`
`784`	`782`	`}`
`785`	`783`	`)`