Skip to content

Commit f88cc2d

Browse files
committed
Fix broken test_appcontext_signals test case
This fixes pallets#781 and ensures that Flask is tested with blinker installed.
1 parent d94b1be commit f88cc2d

6 files changed

+17
-1
lines changed

.travis-devel-requirements.txt

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
git+git://github.com/mitsuhiko/werkzeug.git#egg=Werkzeug
22
git+git://github.com/mitsuhiko/jinja2.git#egg=Jinja2
33
git+git://github.com/mitsuhiko/itsdangerous.git#egg=itsdangerous
4+
5+
# extra dependencies
6+
hg+http://bitbucket.org/jek/blinker#egg=blinker

.travis-lowest-requirements.txt

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
Werkzeug==0.7
22
Jinja2==2.4
33
itsdangerous==0.21
4+
5+
# extra dependencies
6+
blinker==1.0

.travis-release-requirements.txt

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# extra dependencies
2+
blinker

CHANGES

+7
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@ Flask Changelog
33

44
Here you can see the full list of changes between each Flask release.
55

6+
Version 0.10.2
7+
--------------
8+
9+
(bugfix release, release date to be announced)
10+
11+
- Fixed broken `test_appcontext_signals()` test case.
12+
613
Version 0.10.1
714
--------------
815

flask/testsuite/signals.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def test_appcontext_signals(self):
102102
def record_push(sender, **kwargs):
103103
recorded.append('push')
104104
def record_pop(sender, **kwargs):
105-
recorded.append('push')
105+
recorded.append('pop')
106106

107107
@app.route('/')
108108
def index():

tox.ini

+1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@ envlist = py26, py27, pypy, py33
33

44
[testenv]
55
deps = -egit+git://github.com/mitsuhiko/werkzeug.git#egg=werkzeug
6+
blinker
67
commands = python run-tests.py []

0 commit comments

Comments
 (0)