Skip to content

mads: cleanup invalid super().init() #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

mads: cleanup invalid super().init() #197

merged 1 commit into from
Jul 15, 2025

Conversation

devtekve
Copy link

@devtekve devtekve commented Jul 14, 2025

  • Cleans up redundant super().__init__() call.

Summary by Sourcery

Enhancements:

  • Remove redundant super().init() invocation from MadsCarController constructor

- Cleans up redundant `super().__init__()` call.
Copy link

sourcery-ai bot commented Jul 14, 2025

Reviewer's Guide

This PR simplifies the MadsCarController initialization by removing a redundant super().init() call that served no purpose in this context, streamlining the controller setup.

Class diagram for MadsCarController after cleanup

classDiagram
    class MadsCarController {
        +__init__()
        -mads: MadsDataSP
        -lat_disengage_blink: int
    }
Loading

File-Level Changes

Change Details Files
Remove redundant super().init() call
  • Deleted the super().init() invocation in the MadsCarController constructor
opendbc/sunnypilot/car/hyundai/mads.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

Copy link

@Discountchubbs Discountchubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@devtekve devtekve merged commit f406d04 into master-new Jul 15, 2025
4 checks passed
@devtekve devtekve deleted the clean-mads branch July 15, 2025 05:27
mouxangithub added a commit to mouxangithub/opendbc that referenced this pull request Jul 15, 2025
mads: remove unnecessary super init in MadsCarController (sunnypilot#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants