Skip to content

Commit 9078cc5

Browse files
authored
Range over int (#61)
1 parent 56f0550 commit 9078cc5

File tree

8 files changed

+17
-19
lines changed

8 files changed

+17
-19
lines changed

csv/writer.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (w *Writer) WriteFields(fields any) error {
5656
return fmt.Errorf("can not get fieldnames from zero field struct")
5757
}
5858

59-
for i := 0; i < v.NumField(); i++ {
59+
for i := range v.NumField() {
6060
if f := v.Type().Field(i); f.IsExported() {
6161
tag, _ := v.Type().Field(i).Tag.Lookup("csv")
6262
w.fields = append(w.fields, field{v.Type().Field(i).Name, tag})
@@ -147,7 +147,7 @@ func (w *Writer) Write(record any) error {
147147
for i, field := range w.fields {
148148
var val reflect.Value
149149
var found bool
150-
for i := 0; i < v.NumField(); i++ {
150+
for i := range v.NumField() {
151151
if tag, ok := v.Type().Field(i).Tag.Lookup("csv"); ok && tag == field.tag {
152152
val = v.FieldByName(field.name)
153153
found = true
@@ -199,7 +199,7 @@ func (w *Writer) WriteAll(records any) error {
199199
}
200200

201201
v := reflect.ValueOf(records)
202-
for i := 0; i < v.Len(); i++ {
202+
for i := range v.Len() {
203203
if err := w.Write(v.Index(i).Interface()); err != nil {
204204
return err
205205
}

executor/method.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func Execute[T any](argMethod, fnMethod Method, limit int, args []T, fn ...func(
7171
rand.Shuffle(count, func(i, j int) { clone[i], clone[j] = clone[j], clone[i] })
7272
}
7373

74-
for i := 0; i < count; i++ {
74+
for i := range count {
7575
ctx := argContext(len(fn), clone[i])
7676
workers.RunSlice(limit, fn, func(_ int, fn func(T) (any, error)) {
7777
ctx.runFn(fn, result, lasterr)

loadbalance/random.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func WeightedRandom[E any](items ...Weighted[E]) (LoadBalancer[E], error) {
3636
func (r *random[E]) load() {
3737
length := len(r.items)
3838
var s []int
39-
for i := 0; i < length; i++ {
39+
for i := range length {
4040
s = append(s, i)
4141
}
4242
rand.Shuffle(length, func(i, j int) { s[i], s[j] = s[j], s[i] })

loadbalance/random_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ func TestRandom(t *testing.T) {
1818
t.Error(err)
1919
} else {
2020
var res []string
21-
for i := 0; i < 6; i++ {
21+
for range 6 {
2222
res = append(res, loadbalancer.Next())
2323
}
2424
sort.Strings(res)
@@ -32,7 +32,7 @@ func TestRandom(t *testing.T) {
3232
t.Error(err)
3333
} else {
3434
var res []string
35-
for i := 0; i < 8; i++ {
35+
for range 8 {
3636
res = append(res, loadbalancer.Next())
3737
}
3838
sort.Strings(res)

loadbalance/roundrobin_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func TestRoundRobin(t *testing.T) {
1717
t.Error(err)
1818
} else {
1919
var res []string
20-
for i := 0; i < 6; i++ {
20+
for range 6 {
2121
res = append(res, loadbalancer.Next())
2222
}
2323
if expect := []string{a, b, c, a, b, c}; !reflect.DeepEqual(res, expect) {
@@ -30,7 +30,7 @@ func TestRoundRobin(t *testing.T) {
3030
t.Error(err)
3131
} else {
3232
var res []string
33-
for i := 0; i < 8; i++ {
33+
for range 8 {
3434
res = append(res, loadbalancer.Next())
3535
}
3636
if expect := []string{a, a, b, c, a, a, b, c}; !reflect.DeepEqual(res, expect) {

progressbar/progressbar_test.go

+3-5
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,15 @@ func TestProgessBar(t *testing.T) {
1717

1818
pb := New(15).SetRefresh(4 * time.Second)
1919
pb.Start()
20-
for i := int64(0); i < pb.total; i++ {
21-
//log.Print(i)
20+
for range pb.total {
2221
pb.Add(1)
2322
time.Sleep(time.Second)
2423
}
2524
pb.Done()
2625

2726
pb = New(10).SetRefresh(500 * time.Millisecond)
2827
pb.Start()
29-
for i := int64(0); i < pb.total; i++ {
30-
//log.Print(i)
28+
for range pb.total {
3129
pb.Add(1)
3230
time.Sleep(time.Second)
3331
}
@@ -45,7 +43,7 @@ func TestCancel(t *testing.T) {
4543
pb.Cancel()
4644
}()
4745
go func() {
48-
for i := int64(0); i < pb.total; i++ {
46+
for range pb.total {
4947
pb.Add(1)
5048
time.Sleep(time.Second)
5149
}

retry/retry.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func ErrNoMoreRetry(err string) error { return errorNoMoreRetry(err) }
3636
// Do keeps retrying the function until no error is returned.
3737
func Do(fn func() error, attempts, delay int) error {
3838
var errs []error
39-
for i := 0; i < attempts; i++ {
39+
for i := range attempts {
4040
err := fn()
4141
if err == nil {
4242
return nil

workers/workers.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -71,15 +71,15 @@ func RunSlice[E any](limit int, s []E, f func(int, E)) {
7171
}
7272

7373
c := make(chan struct{}, limit)
74-
for i := 0; i < len(s); i++ {
74+
for i := range len(s) {
7575
c <- struct{}{}
7676
go func(index int, value E) {
7777
defer func() { <-c }()
7878
f(index, value)
7979
}(i, s[i])
8080
}
8181

82-
for i := 0; i < limit; i++ {
82+
for range limit {
8383
c <- struct{}{}
8484
}
8585
close(c)
@@ -102,7 +102,7 @@ func RunMap[K comparable, V any](limit int, m map[K]V, f func(K, V)) {
102102
}(k, v)
103103
}
104104

105-
for i := 0; i < limit; i++ {
105+
for range limit {
106106
c <- struct{}{}
107107
}
108108
close(c)
@@ -129,7 +129,7 @@ func RunRange[Int Integer](limit int, start, end Int, f func(Int)) {
129129
}(i)
130130
}
131131

132-
for i := 0; i < limit; i++ {
132+
for range limit {
133133
c <- struct{}{}
134134
}
135135
close(c)

0 commit comments

Comments
 (0)