Skip to content

detectSuperJson incorrectly returns path relative to fs.cwd() instead of user provided cwd. #315

Open
@TheEdward162

Description

@TheEdward162

fileSystem.path.cwd(),

The function uses recursion and taints its own cwd parameter. Later uses the filesystem cwd to create a relative path to return. This is incorrect since the point of passing in a cwd is for the function to work relative to that, not the filesystem cwd. Alternatively it could rely solely on the filesystem cwd (since the caller has a chance to modify it) and remove the cwd parameter

This bug only manifests when the cwd argument is not the same as the process cwd, such as when running in vscode extension.

I'm not sure what the callsites of this function are since CLI uses its own version of this function (rather, this function is probably based on the one in CLI).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions