Skip to content

[BUG] OneSDK configuration using environmental variables do not work #343

Open
@janhalama

Description

@janhalama

OneSDK configuration using environmental variables do not work in case that options parameter of SuperfaceClient is defined.

This is relevant for environment variables that have defined default value in OneSDK package. This is list of affected env variables:

  • SUPERFACE_API_URL
  • SUPERFACE_PATH
  • SUPERFACE_METRIC_DEBOUNCE_TIME_MIN
  • SUPERFACE_METRIC_DEBOUNCE_TIME_MAX
  • SUPERFACE_DISABLE_METRIC_REPORTING
  • SUPERFACE_SANDBOX_TIMEOUT
  • SUPERFACE_CACHE_TIMEOUT

The bug is not affecting SUPERFACE_SDK_TOKEN env variable.

Expected Behavior

Configuration of OneSDK should be possible using combination of code and environment variables. Code configuration should take priority over environmental variables.

Current Behavior

At this moment once single options parameter is configured in code, environment variables can not be used for OneSDK configuration.

Possible Solution

Merge default params after merging code and env config params.

Steps to Reproduce

MRE repository: https://github.com/janhalama/one-sdk-config-bug-example

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions