chore: make analyzers happy (#526)

Author: knopp

super_context_menu/lib/src/default_builder/mobile_menu_widget_builder.dart

@@ -379,7 +379,7 @@ extension on Menu {
 
 class _MenuItem extends StatelessWidget {
   const _MenuItem({
-    // ignore: unused_element
+    // ignore: unused_element_parameter
     super.key,
     required this.menuInfo,
     required this.state,
@@ -463,7 +463,7 @@ class _MenuItem extends StatelessWidget {
 
 class _MenuHeader extends StatelessWidget {
   const _MenuHeader({
-    // ignore: unused_element
+    // ignore: unused_element_parameter
     super.key,
     required this.menuInfo,
     required this.state,
@@ -526,7 +526,7 @@ class _MenuHeader extends StatelessWidget {
 
 class _MenuItemScaffold extends StatelessWidget {
   const _MenuItemScaffold({
-    // ignore: unused_element
+    // ignore: unused_element_parameter
     super.key,
     this.prefix,
     this.suffix,

super_context_menu/lib/src/scaffold/mobile/menu_widget.dart

@@ -188,7 +188,7 @@ typedef _MenuButtonBuilder = Widget Function(
 
 class _MenuButton extends StatefulWidget {
   const _MenuButton({
-    // ignore: unused_element
+    // ignore: unused_element_parameter
     super.key,
     required this.enabled,
     required this.onTapUp,

super_native_extensions/lib/src/widget_snapshot/widget_snapshotter_internal.dart

@@ -343,7 +343,7 @@ class SnapshotSettingsState extends State<SnapshotSettings> {
 
 class _SnapshotLayout extends MultiChildRenderObjectWidget {
   const _SnapshotLayout({
-    // ignore: unused_element
+    // ignore: unused_element_parameter
     super.key,
     required super.children,
   });

super_native_extensions/rust/src/android/reader.rs

@@ -106,8 +106,8 @@ impl PlatformDataReader {
                 .await?;
             if let Value::String(url) = uri {
                 if let Ok(url) = Url::parse(&url) {
-                    if let Some(segments) = url.path_segments() {
-                        let last: Option<&str> = segments.last().filter(|s| !s.is_empty());
+                    if let Some(mut segments) = url.path_segments() {
+                        let last: Option<&str> = segments.next_back().filter(|s| !s.is_empty());
                         return Ok(last.map(|f| f.to_owned()));
                     }
                 }

super_native_extensions/rust/src/context.rs

@@ -56,7 +56,7 @@ impl Context {
         result
     }
 
-    pub fn get_attachment<T: Any, F: FnOnce() -> T>(&self, on_init: F) -> Ref<T> {
+    pub fn get_attachment<T: Any, F: FnOnce() -> T>(&self, on_init: F) -> Ref<'_, T> {
         let id = TypeId::of::<T>();
         // Do a separate check here, make sure attachments is not borrowed while
         // creating the attachment
@@ -109,7 +109,7 @@ impl Drop for Context {
     fn drop(&mut self) {
         if self.outermost {
             // Remove attachment in reverse order in which they were inserted
-            while self.internal.attachments.borrow().len() > 0 {
+            while !self.internal.attachments.borrow().is_empty() {
                 let to_remove_index = self.internal.attachments.borrow().len() - 1;
                 let to_remove = self
                     .internal

super_native_extensions/rust/src/darwin/macos/hot_key_sys.rs

@@ -6,6 +6,7 @@ pub type EventTargetRef = *mut ::std::os::raw::c_void;
 pub type EventHandlerRef = *mut ::std::os::raw::c_void;
 pub type EventHandlerCallRef = *mut ::std::os::raw::c_void;
 pub type EventRef = *mut ::std::os::raw::c_void;
+#[allow(non_snake_case)]
 pub type EventHandlerUPP = ::std::option::Option<
     unsafe extern "C" fn(
         inHandlerCallRef: EventHandlerCallRef,

super_native_extensions/rust/src/darwin/macos/keyboard_layout_sys.rs

@@ -29,6 +29,7 @@ extern "C" {
     );
 }
 
+#[allow(non_snake_case)]
 pub type CFNotificationCallback = Option<
     extern "C" fn(
         center: CFNotificationCenterRef,

super_native_extensions/rust/src/linux/reader.rs

@@ -143,8 +143,8 @@ impl PlatformDataReader {
         let item = item as usize;
         let uri = self.inner.uris.get(item).and_then(|u| Url::parse(u).ok());
         if let Some(uri) = uri {
-            if let Some(segments) = uri.path_segments() {
-                let last: Option<&str> = segments.last().filter(|s| !s.is_empty());
+            if let Some(mut segments) = uri.path_segments() {
+                let last: Option<&str> = segments.next_back().filter(|s| !s.is_empty());
                 return Ok(last.map(|f| f.to_owned()));
             }
         }
@@ -158,7 +158,7 @@ impl PlatformDataReader {
         let item = item as usize;
         let uri = self.inner.uris.get(item).and_then(|u| Url::parse(u).ok());
         if let Some(uri) = uri {
-            let name: Option<&str> = uri.path_segments().and_then(|s| s.last());
+            let name: Option<&str> = uri.path_segments().and_then(|mut s| s.next_back());
             match name {
                 Some(name) => {
                     let format = mime_from_name(name);