Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests that utilize the client and server #106

Open
spkane opened this issue Jan 24, 2022 · 0 comments
Open

Add integration tests that utilize the client and server #106

spkane opened this issue Jan 24, 2022 · 0 comments
Labels
next Higher priority issues tests Testing related

Comments

@spkane
Copy link
Contributor

spkane commented Jan 24, 2022

We should add some integration tests that ensure that the client and server work well in complex real-world scenarios.

Examples:

  • User with no matching key in the server and no github user
  • User with no matching key in the server, a github user, and a matching github key
  • User with multiple keys in their path, some invalid, some missing from disk, but a valid one at the end of the list.
  • CLI run from a repo that overrides/merges into the user's existing config
  • etc...
@spkane spkane added tests Testing related next Higher priority issues labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Higher priority issues tests Testing related
Projects
None yet
Development

No branches or pull requests

1 participant