Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify CI steps on main when a new release isn't being created #88

Open
spkane opened this issue Jan 15, 2022 · 2 comments
Open

Verify CI steps on main when a new release isn't being created #88

spkane opened this issue Jan 15, 2022 · 2 comments
Labels
dev-process Dev process related

Comments

@spkane
Copy link
Contributor

spkane commented Jan 15, 2022

  • We always push containers on a PR, but we shouldn't push new containers on main without a release, since that will push unreleased code under the :latest tag. Or we should pick a special tag for these :unreleased and not overwrite :latest, which should probably be latest stable.
  • We should also only run UPX if we actually built the binaries, which we only do on a release.
@tammersaleh
Copy link
Member

I was just thinking how it might be useful to have binaries produced for every commit, but pushed to the unreleased (or some sort of other track) on github. Same for docker images. What do you think?

@spkane
Copy link
Contributor Author

spkane commented Jan 18, 2022

I have thought about this. It would be easier with the containers, then the binaries, since we are using Github releases to distribute the binaries, but there are likely a few ways we could solve this, so it is worth thinking about some more.

@spkane spkane added feature New feature dev-process Dev process related and removed feature New feature labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-process Dev process related
Projects
None yet
Development

No branches or pull requests

2 participants