fixed eslint errors

Author: suxrobGM

src/Client/Logistics.OfficeApp/.eslintignore

@@ -1,7 +1,7 @@
 {
   "editor.tabSize": 2,
   "editor.defaultFormatter": "esbenp.prettier-vscode",
-  "prettier.configPath": "./.prettierrc.mjs",
+  "prettier.configPath": "./.prettierrc.js",
   "files.exclude": {
     "**/node_modules": true,
     "**/.angular": true,

src/Client/Logistics.OfficeApp/.eslintrc.json

@@ -1,6 +1,8 @@
 {
   "name": "logistics.office-app",
   "version": "0.0.0",
+  "private": true,
+  "type": "module",
   "scripts": {
     "ng": "ng",
     "start": "ng serve --port 7003",
@@ -11,7 +13,6 @@
     "lint": "ng lint",
     "prettier": "prettier --write ./src"
   },
-  "private": true,
   "dependencies": {
     "@angular/animations": "^18.2.7",
     "@angular/common": "^18.2.7",
@@ -37,24 +38,19 @@
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "^18.2.7",
-    "@angular-eslint/builder": "^18.3.1",
-    "@angular-eslint/eslint-plugin": "^18.3.1",
-    "@angular-eslint/eslint-plugin-template": "^18.3.1",
-    "@angular-eslint/schematics": "^18.3.1",
-    "@angular-eslint/template-parser": "^18.3.1",
     "@angular/cli": "^18.2.7",
     "@angular/compiler-cli": "^18.2.7",
     "@types/jasmine": "^5.1.4",
     "@types/mapbox-gl": "^3.4.0",
-    "@typescript-eslint/eslint-plugin": "^8.8.0",
-    "@typescript-eslint/parser": "^8.8.0",
+    "angular-eslint": "^18.3.1",
     "eslint": "^9.12.0",
     "jasmine-core": "^5.3.0",
     "karma": "^6.4.4",
     "karma-chrome-launcher": "^3.2.0",
     "karma-coverage": "^2.2.1",
     "karma-jasmine": "^5.1.0",
     "karma-jasmine-html-reporter": "^2.1.0",
-    "typescript": "^5.4.5"
+    "typescript": "^5.4.5",
+    "typescript-eslint": "^8.8.0"
   }
 }

src/Client/Logistics.OfficeApp/.prettierrc.mjs

@@ -90,7 +90,12 @@ export class AddressFormComponent implements ControlValueAccessor {
   }
 
   setDisabledState(isDisabled: boolean): void {
-    isDisabled ? this.form.disable() : this.form.enable();
+    if (isDisabled) {
+      this.form.disable();
+    }
+    else {
+      this.form.enable();
+    }
   }
 }
 

src/Client/Logistics.OfficeApp/.vscode/settings.json

@@ -62,15 +62,15 @@ export class DirectionsMapComponent implements OnChanges {
         return;
       }
 
-      (this.route = {
+      this.route = {
         type: "geojson",
         data: {
           type: "Feature",
           geometry: data.routes[0].geometry,
           properties: {},
         },
-      }),
-        (this.bounds = [this.start as LngLatLike, this.end as LngLatLike]);
+      },
+      this.bounds = [this.start as LngLatLike, this.end as LngLatLike];
       this.routeChanged.emit({
         origin: this.start!,
         destination: this.end!,

src/Client/Logistics.OfficeApp/bun.lockb

@@ -73,8 +73,8 @@ export class GrossesBarchartComponent implements OnInit {
   }
 
   private drawChart(grosses: MonthlyGrossesDto) {
-    const labels: Array<string> = [];
-    const data: Array<number> = [];
+    const labels: string[] = [];
+    const data: number[] = [];
 
     grosses.data.forEach((i) => {
       labels.push(DateUtils.monthNameWithYear(i.date));

src/Client/Logistics.OfficeApp/eslint.config.mjs

@@ -4,7 +4,8 @@
 <button
   pButton
   class="p-button-raised ms-2"
-  label="Apply"
   [disabled]="!areDatesValid()"
   (click)="onClickButton()"
-></button>
+>
+Apply
+</button>

src/Client/Logistics.OfficeApp/package.json

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {Component, Input, OnDestroy, OnInit} from "@angular/core";
 import {CommonModule} from "@angular/common";
 import {GeolocationMapComponent} from "@/components";

src/Client/Logistics.OfficeApp/src/app/components/address-form/address-form.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable indent */
 import {Injectable} from "@angular/core";
 import {EventTypes, OidcSecurityService, PublicEventsService} from "angular-auth-oidc-client";
 import {Observable, filter, map} from "rxjs";

src/Client/Logistics.OfficeApp/src/app/components/directions-map/directions-map.component.ts

@@ -3,14 +3,13 @@ import {Injectable} from "@angular/core";
 @Injectable()
 export class CookieService {
   getCookie(name: string): string {
-    const cookies: Array<string> = document.cookie.split(";");
+    const cookies = document.cookie.split(";");
     const cookieName = `${name}=`;
-    let cookie: string;
 
-    for (let i = 0; i < cookies.length; i += 1) {
-      cookie = cookies[i].replace(/^\s+/g, "");
-      if (cookie.indexOf(cookieName) == 0) {
-        return cookie.substring(cookieName.length, cookie.length);
+    for (const cookie of cookies) {
+      const cookieValue = cookie.replace(/^\s+/g, "");
+      if (cookieValue.indexOf(cookieName) == 0) {
+        return cookieValue.substring(cookieName.length, cookieValue.length);
       }
     }
     return "";
@@ -31,7 +30,7 @@ export class CookieService {
    * {service instance}.setCookie({name:'niceCar', value:'red', expireDays:10 }); <- For all this examples if path is not provided default will be root
    */
   setCookie(cookie: Cookie) {
-    const date: Date = new Date();
+    const date = new Date();
     date.setTime(date.getTime() + (cookie.expireDays ? cookie.expireDays : 1) * 24 * 60 * 60 * 1000);
     const path = cookie.path && cookie.path.length > 0 ? cookie.path : "/";
     const expires = cookie.session && cookie.session == true ? "" : `expires=${date.toUTCString()};`;

src/Client/Logistics.OfficeApp/src/app/components/grosses-barchart/grosses-barchart.component.ts

@@ -5,7 +5,9 @@ export class StorageService {
   get<T = unknown>(name: string): T | null {
     try {
       return JSON.parse(localStorage.getItem(name) as string) as T;
-    } catch (error) {
+    }
+    catch (error) {
+      console.error("Error while parsing data from local storage", error);
       return null;
     }
   }

src/Client/Logistics.OfficeApp/src/app/components/range-calendar/range-calendar.component.html

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {Component, OnInit} from "@angular/core";
 import {CommonModule} from "@angular/common";
 import {FormControl, FormGroup, ReactiveFormsModule, Validators} from "@angular/forms";

src/Client/Logistics.OfficeApp/src/app/components/trucks-map/trucks-map.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {Component, OnInit} from "@angular/core";
 import {CommonModule} from "@angular/common";
 import {FormGroup, FormControl, Validators, ReactiveFormsModule} from "@angular/forms";

src/Client/Logistics.OfficeApp/src/app/core/auth/auth.service.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {Component, OnInit} from "@angular/core";
 import {CommonModule} from "@angular/common";
 import {FormControl, FormGroup, ReactiveFormsModule, Validators} from "@angular/forms";

src/Client/Logistics.OfficeApp/src/app/core/services/cookie.service.ts

@@ -1,4 +1,3 @@
-/* eslint-disable indent */
 import {Injectable} from "@angular/core";
 import {map, Observable} from "rxjs";
 import {RoleDto, UserDto} from "@/core/models";

src/Client/Logistics.OfficeApp/src/app/core/services/storage.service.ts

@@ -51,22 +51,22 @@ export class HomeComponent implements OnInit {
   public chartOptions: unknown;
 
   constructor(private readonly apiService: ApiService) {
-    (this.chartData = {
+    this.chartData = {
       labels: [],
       datasets: [
         {
           label: "Daily Gross",
           data: [],
         },
       ],
-    }),
-      (this.chartOptions = {
-        plugins: {
-          legend: {
-            display: false,
-          },
+    },
+    this.chartOptions = {
+      plugins: {
+        legend: {
+          display: false,
         },
-      });
+      },
+    };
   }
 
   ngOnInit() {
@@ -106,8 +106,8 @@ export class HomeComponent implements OnInit {
   }
 
   private drawChart(grosses: DailyGrossesDto) {
-    const labels: Array<string> = [];
-    const data: Array<number> = [];
+    const labels: string[] = [];
+    const data: number[] = [];
 
     grosses.data.forEach((i) => {
       labels.push(DateUtils.toLocaleDate(i.date));

src/Client/Logistics.OfficeApp/src/app/pages/accounting/edit-payment/edit-payment.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {Component, OnInit} from "@angular/core";
 import {NgIf} from "@angular/common";
 import {FormControl, FormGroup, Validators, FormsModule, ReactiveFormsModule} from "@angular/forms";

src/Client/Logistics.OfficeApp/src/app/pages/accounting/edit-payroll/edit-payroll.component.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {Component, OnInit} from "@angular/core";
 import {CommonModule} from "@angular/common";
 import {FormControl, FormGroup, Validators, FormsModule, ReactiveFormsModule} from "@angular/forms";

src/Client/Logistics.OfficeApp/src/app/pages/customer/edit-customer/edit-customer.component.ts

@@ -71,8 +71,8 @@ export class TruckGrossesLinechartComponent implements OnInit {
   }
 
   private drawChart(grosses: DailyGrossesDto) {
-    const labels: Array<string> = [];
-    const data: Array<number> = [];
+    const labels: string[] = [];
+    const data: string[] = [];
 
     grosses.data.forEach((i) => {
       labels.push(DateUtils.toLocaleDate(i.date));