Impact
This vulnerability impacts generated code. If this code was generated as a one-off occasion, not as a part of an automated CI/CD process, this code will remain vulnerable until fixed manually!
On Unix-Like systems, the system temporary directory is shared between all local users. When files/directories are created, the default umask settings for the process are respected. As a result, by default, most processes/apis will create files/directories with the permissions -rw-r--r-- and drwxr-xr-x respectively, unless an API that explicitly sets safe file permissions is used.
Java Code
The method File.createTempFile from the JDK is vulnerable to this local information disclosure vulnerability.
|
return File.createTempFile(prefix, suffix); |
|
val file = File.createTempFile("tmp{{classname}}", null) |
|
if (tempFolderPath == null) |
|
return File.createTempFile(prefix, suffix); |
|
else |
|
return File.createTempFile(prefix, suffix, new File(tempFolderPath)); |
|
if (tempFolderPath == null) |
|
return File.createTempFile(prefix, suffix); |
|
else |
|
return File.createTempFile(prefix, suffix, new File(tempFolderPath)); |
Patches
Fix has been applied to the master branch with:
included in release: 2.4.19
Workarounds
Users can remediate the vulnerability in non patched version by manually (or programmatically e.g. in CI) updating the generated source code to use java.nio.files.Files temporary file creation instead of java.io.File, e.g. by changing
if (tempFolderPath == null)
return File.createTempFile(prefix, suffix);
else
return File.createTempFile(prefix, suffix, new File(tempFolderPath));to
if (tempFolderPath == null)
return Files.createTempFile(prefix, suffix).toFile();
else
return Files.createTempFile(Paths.get(tempFolderPath), prefix, suffix).toFile();or generally changing:
File.createTempFile(prefix, suffix);
to
Files.createTempFile(prefix, suffix).toFile();
References
For more information
If you have any questions or comments about this advisory:
Original vulnerability report
I'm performing OSS security research under the GitHub Security Lab Bug Bounty program.
I've been using a custom CodeQL query to find local temporary directory vulnerabilities in OSS with three custom CodeQL queries.
The code generated by the Swagger Generator contains a local information disclosure vulnerability. The system temporary directory, on unix-like systems is shared between multiple users. Information written to this directory, or directories created under this directory that do not correctly set the posix standard permissions can have these directories read/modified by other users.
This code exists in the code generator, in the generated code.
In this case, I believe this is only a local information disclosure. IE. another user can read the information, not replace it.
In particular, the method File.createTempFile from the JDK is vulnerable to this local information disclosure vulnerability.
This is because File.createTempFile creates a file inside of the system temporary directory with the permissions: -rw-r--r--. Thus the contents of this file are viewable by all other users locally on the system.
|
return File.createTempFile(prefix, suffix); |
|
val file = File.createTempFile("tmp{{classname}}", null) |
|
if (tempFolderPath == null) |
|
return File.createTempFile(prefix, suffix); |
|
else |
|
return File.createTempFile(prefix, suffix, new File(tempFolderPath)); |
|
if (tempFolderPath == null) |
|
return File.createTempFile(prefix, suffix); |
|
else |
|
return File.createTempFile(prefix, suffix, new File(tempFolderPath)); |
The fix here is to switch to the Files API, instead of File as that appropriately sets the file permissions.
JLLeitschuh Analyst
Impact
This vulnerability impacts generated code. If this code was generated as a one-off occasion, not as a part of an automated CI/CD process, this code will remain vulnerable until fixed manually!
On Unix-Like systems, the system temporary directory is shared between all local users. When files/directories are created, the default
umasksettings for the process are respected. As a result, by default, most processes/apis will create files/directories with the permissions-rw-r--r--anddrwxr-xr-xrespectively, unless an API that explicitly sets safe file permissions is used.Java Code
The method
File.createTempFilefrom the JDK is vulnerable to this local information disclosure vulnerability.swagger-codegen/modules/swagger-codegen/src/main/resources/kotlin-client/infrastructure/ApiClient.kt.mustache
Line 209 in 068b1eb
swagger-codegen/modules/swagger-codegen/src/main/resources/finch/api.mustache
Line 84 in 068b1eb
swagger-codegen/modules/swagger-codegen/src/main/resources/Java/libraries/okhttp-gson/ApiClient.mustache
Lines 831 to 834 in 068b1eb
swagger-codegen/modules/swagger-codegen/src/main/resources/Java/libraries/jersey2/ApiClient.mustache
Lines 630 to 633 in 068b1eb
Patches
Fix has been applied to the master branch with:
included in release: 2.4.19
Workarounds
Users can remediate the vulnerability in non patched version by manually (or programmatically e.g. in CI) updating the generated source code to use
java.nio.files.Filestemporary file creation instead ofjava.io.File, e.g. by changingto
or generally changing:
to
References
For more information
If you have any questions or comments about this advisory:
Original vulnerability report