Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder as definition-file #138

Open
Peredery opened this issue Feb 21, 2022 · 2 comments
Open

folder as definition-file #138

Peredery opened this issue Feb 21, 2022 · 2 comments

Comments

@Peredery
Copy link

Peredery commented Feb 21, 2022

folder support like definition-file ? :)

It would be nice to add this option

@char0n
Copy link
Member

char0n commented Feb 22, 2022

Hi @Peredery,

Well it would be possible for sure. But instead of pointing to a directory, glob patterns would be IMHO a better option. glob patterns will fetch files necessary to validate. The directory use-case would be supported by following glob pattern: /path/to/directory/**/*.*

This change would require changing the architecture of this GitHub Actions though. Mechanism like stop on first error or continue on error will need to be introduced as well.

Currently, missing support for validating multiple files can be bypassed by setting multiple validation jobs pointing to different files.

@Peredery
Copy link
Author

glob patterns

agree that "glob patterns" is the better solution for this 👍

Now I'm iterating over the list of files inside the directory (each validation as a separate step in GithuibAction)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants