avoid raising error when removing non-existent image #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 58.09% 58.18% +0.09%
==========================================
Files 20 20
Lines 1971 1973 +2
==========================================
+ Hits 1145 1148 +3
+ Misses 826 825 -1 ☔ View full report in Codecov by Sentry. |
lycfight
pushed a commit
to lycfight/SWE-bench
that referenced
this pull request
Mar 5, 2025
…raise-error-on-img-removal avoid raising error when removing non-existent image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
swebench/harness/docker_utils.pysometimes, during cleaning, an image is marked for removal even if it doesn't exist (tbh not 100% why this happens), but when we try to remove a non-existent image, we get an error that interrupts execution.There are currently no consequences to trying to remove a non-existent image, and the interruption is annoying, so we now should avoid throwing an error in those cases and instead just log the incident. We'll still get errors in other cases.