Skip to content

Consider removing build number from release asset #433

Open
@fenhl

Description

@fenhl
Contributor

I'm trying to get SwiftBar updated in Homebrew and ran into 2 issues:

  1. The method recommended by the contributing guide to update a cask, brew bump --open-pr swiftbar, didn't work because it was looking for the release asset with build number b520 from 2.0.0, while 2.0.1 uses b536, so I had to create the PR manually.
  2. One of the required verification steps, brew audit --cask --online swiftbar, fails for presumably the same reason.

If the build number were removed from the filename, that would make automation tasks like this easier to set up.

Activity

melonamin

melonamin commented on Feb 27, 2025

@melonamin
Contributor

You are saying that having a stable SwiftBar.zip will help to address this issue?

fenhl

fenhl commented on Feb 27, 2025

@fenhl
ContributorAuthor

SwiftBar.v2.0.1.zip, without the b536 part, should also be fine. The version number is already required to build the full URL after all.

melonamin

melonamin commented on Feb 27, 2025

@melonamin
Contributor

Updated in the latest release, so you can give it a try.

I would need to update the Sparkle thingy, but that shouldn't be too much work.

added a commit that references this issue on Feb 27, 2025
fenhl

fenhl commented on Feb 27, 2025

@fenhl
ContributorAuthor

Thanks, I can't test it anymore because the PR already exists now, but we'll know for sure on the next release after 2.0.1.

fenhl

fenhl commented on Mar 2, 2025

@fenhl
ContributorAuthor

Looking at https://github.com/swiftbar/SwiftBar/releases/tag/v2.0.1 it seems like the release asset name was reverted to include the build number again. I had removed it from the Homebrew PR (Homebrew/homebrew-cask#203229) following #433 (comment).

@melonamin Was this intentional? Should we adjust Homebrew to include the build number again?

melonamin

melonamin commented on Mar 2, 2025

@melonamin
Contributor

@fenhl Yeah, I did it yesterday on the go and forgot to comment here; sorry.

Autoupdate relies on this versioning scheme, and there is no easy way to fix it, so we're stuck with it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @melonamin@fenhl@mtscope

        Issue actions

          Consider removing build number from release asset · Issue #433 · swiftbar/SwiftBar