From 5a4720a6ba6bd7e9c6ade0ec55484a350aaf2f67 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 13 Sep 2024 13:42:55 -0700 Subject: [PATCH] [lldb] Emit signpost intervals for progress events (NFC) (#108498) Emit signpost intervals for progress events so that when users report an operation takes a long time, we can investigate the issue with Instruments.app. (cherry picked from commit 90f077cba8f41a2ba0eb8ffebed8da48322ed0d7) --- lldb/source/Core/Progress.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lldb/source/Core/Progress.cpp b/lldb/source/Core/Progress.cpp index e0ba1a63c508e5..27774ce7a5521b 100644 --- a/lldb/source/Core/Progress.cpp +++ b/lldb/source/Core/Progress.cpp @@ -10,6 +10,7 @@ #include "lldb/Core/Debugger.h" #include "lldb/Utility/StreamString.h" +#include "llvm/Support/Signposts.h" #include #include @@ -20,6 +21,9 @@ using namespace lldb_private; std::atomic Progress::g_id(0); +// Instrument progress events with signposts when supported. +static llvm::ManagedStatic g_progress_signposts; + Progress::Progress(std::string title, std::string details, std::optional total, lldb_private::Debugger *debugger) @@ -39,9 +43,15 @@ Progress::Progress(std::string title, std::string details, // Report to the ProgressManager if that subsystem is enabled. if (ProgressManager::Enabled()) ProgressManager::Instance().Increment(m_progress_data); + + // Start signpost interval right before the meaningful work starts. + g_progress_signposts->startInterval(this, m_progress_data.title); } Progress::~Progress() { + // End signpost interval as soon as possible. + g_progress_signposts->endInterval(this, m_progress_data.title); + // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex);