Make article-only catalog pages language-less #240
Labels
bug
Something isn't working
Comments
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
May 9, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
May 9, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
3 tasks
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
May 10, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
May 10, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
May 10, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
May 12, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
that referenced
this issue
May 12, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com//issues/240). rdar://92758192
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
Jun 9, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
to franklinsch/swift-docc
that referenced
this issue
Jun 9, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com/swiftlang/issues/240). rdar://92758192
franklinsch
added a commit
that referenced
this issue
Jun 9, 2022
For article-only catalogs, i.e., catalogs that use @TechnologyRoot, don't emit the variants array in the render node, so that renderers don't display the page's language, since it doesn't have a language. A longer-term fix here would be to not consider articles in article-only catalogs to be "Swift", and implement logic in RenderNodeTranslator to not emit variants information for language-less pages (github.com//issues/240). rdar://92758192
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the language of pages in article-only catalogs, i.e., catalogs that define a
@TechnologyRoot, is "Swift" (arbitrarily), since there isn't really a language that can be inferred for them.We should instead track these as language-less (
availableSourceLanguages: []) or as a special.undefinedlanguage. This will require relaxing the navigator index logic to still include these pages, despite not being of language Swift, Objective-C, or Data.Swift-DocC Version Information
Swift-DocC version: e761687
rdar://118461894
The text was updated successfully, but these errors were encountered: