Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant fallback value for a module's symbol name. #249

Open
d-ronnqvist opened this issue May 10, 2022 · 0 comments
Open

Remove redundant fallback value for a module's symbol name. #249

d-ronnqvist opened this issue May 10, 2022 · 0 comments
Labels
enhancement Improvements or enhancements to existing functionality

Comments

@d-ronnqvist
Copy link
Contributor

The code that computes the module name in #161 uses a fallback value if the node doesn't have a symbol but module nodes should always have a symbol.

We should remove this fallback value and force unwrap instead, but only on the main branch, not on the release/5.7 branch.
@d-ronnqvist d-ronnqvist added the enhancement Improvements or enhancements to existing functionality label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements or enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-ronnqvist