Skip to content

Commit 7c3e4a1

Browse files
committedJan 17, 2025··
Remove now-unused dependency on yams package

File tree

6 files changed

+1
-48
lines changed

6 files changed

+1
-48
lines changed
 

‎CMakeLists.txt

-9
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,6 @@ if(NOT TSC_FOUND)
8787
FetchContent_MakeAvailable(ToolsSupportCore)
8888
endif()
8989

90-
find_package(Yams CONFIG)
91-
if(NOT Yams_FOUND)
92-
message("-- Vending yams")
93-
FetchContent_Declare(Yams
94-
GIT_REPOSITORY https://github.com/jpsim/yams
95-
GIT_TAG 5.0.6)
96-
FetchContent_MakeAvailable(Yams)
97-
endif()
98-
9990
set(BUILD_TESTING ${_SD_SAVED_BUILD_TESTING})
10091
set(BUILD_EXAMPLES ${_SD_SAVED_BUILD_EXAMPLES})
10192

‎Package.resolved

-9
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,6 @@
3535
"branch" : "main",
3636
"revision" : "4074f4db0971328c441fc1621c673937b9ca3b08"
3737
}
38-
},
39-
{
40-
"identity" : "yams",
41-
"kind" : "remoteSourceControl",
42-
"location" : "https://github.com/jpsim/Yams.git",
43-
"state" : {
44-
"revision" : "3036ba9d69cf1fd04d433527bc339dc0dc75433d",
45-
"version" : "5.1.3"
46-
}
4738
}
4839
],
4940
"version" : 2

‎Package.swift

-3
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ let package = Package(
5353
"SwiftOptions",
5454
.product(name: "SwiftToolsSupport-auto", package: "swift-tools-support-core"),
5555
"CSwiftScan",
56-
.product(name: "Yams", package: "yams"),
5756
],
5857
exclude: ["CMakeLists.txt"]),
5958

@@ -166,7 +165,6 @@ if ProcessInfo.processInfo.environment["SWIFT_DRIVER_LLBUILD_FWK"] == nil {
166165
if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {
167166
package.dependencies += [
168167
.package(url: "https://github.com/apple/swift-tools-support-core.git", branch: "main"),
169-
.package(url: "https://github.com/jpsim/Yams.git", .upToNextMinor(from: "5.1.0")),
170168
// The 'swift-argument-parser' version declared here must match that
171169
// used by 'swift-package-manager' and 'sourcekit-lsp'. Please coordinate
172170
// dependency version changes here with those projects.
@@ -175,7 +173,6 @@ if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {
175173
} else {
176174
package.dependencies += [
177175
.package(path: "../swift-tools-support-core"),
178-
.package(path: "../yams"),
179176
.package(path: "../swift-argument-parser"),
180177
]
181178
}

‎README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,10 @@ all with CMake:
6565
cmake -B <llbuild-build-dir> -G Ninja <llbuild-source-dir> -DLLBUILD_SUPPORT_BINDINGS="Swift" -DCMAKE_OSX_ARCHITECTURES=x86_64
6666
```
6767
* [swift-argument-parser](https://github.com/apple/swift-argument-parser)
68-
* [Yams](https://github.com/jpsim/Yams)
6968

7069
Once those dependencies have built, build `swift-driver` itself:
7170
```
72-
cmake -B <swift-driver-build-dir> -G Ninja <swift-driver-source-dir> -DTSC_DIR=<swift-tools-support-core-build-dir>/cmake/modules -DLLBuild_DIR=<llbuild-build-dir>/cmake/modules -DYams_DIR=<yamls-build-dir>/cmake/modules -DArgumentParser_DIR=<swift-argument-parser-build-dir>
71+
cmake -B <swift-driver-build-dir> -G Ninja <swift-driver-source-dir> -DTSC_DIR=<swift-tools-support-core-build-dir>/cmake/modules -DLLBuild_DIR=<llbuild-build-dir>/cmake/modules -DArgumentParser_DIR=<swift-argument-parser-build-dir>
7372
cmake --build <swift-driver-build-dir>
7473
```
7574

‎Sources/SwiftDriver/CMakeLists.txt

-2
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@ target_link_libraries(SwiftDriver PUBLIC
131131
TSCUtility
132132
SwiftOptions)
133133
target_link_libraries(SwiftDriver PRIVATE
134-
CYaml
135-
Yams
136134
CSwiftScan)
137135

138136
set_property(GLOBAL APPEND PROPERTY SWIFTDRIVER_EXPORTS SwiftDriver)

‎Utilities/build-script-helper.py

-23
Original file line numberDiff line numberDiff line change
@@ -445,9 +445,6 @@ def build_using_cmake(args, toolchain_bin, build_dir, targets):
445445
# Argument Parser
446446
build_argument_parser_using_cmake(args, target, swiftc_exec, dependencies_dir,
447447
base_cmake_flags, swift_flags)
448-
# Yams
449-
build_yams_using_cmake(args, target, swiftc_exec, dependencies_dir,
450-
base_cmake_flags, swift_flags)
451448
# SwiftDriver
452449
build_swift_driver_using_cmake(args, target, swiftc_exec, driver_dir,
453450
base_cmake_flags, swift_flags)
@@ -489,25 +486,6 @@ def build_tsc_using_cmake(args, target, swiftc_exec, build_dir, base_cmake_flags
489486
cmake_build(args, swiftc_exec, tsc_cmake_flags, tsc_swift_flags,
490487
tsc_source_dir, tsc_build_dir)
491488

492-
def build_yams_using_cmake(args, target, swiftc_exec, build_dir, base_cmake_flags, swift_flags):
493-
print('Building Swift Driver dependency: Yams')
494-
yams_source_dir = os.path.join(os.path.dirname(args.package_path), 'yams')
495-
yams_build_dir = os.path.join(build_dir, 'yams')
496-
yams_cmake_flags = base_cmake_flags + [
497-
'-DCMAKE_C_COMPILER:=clang',
498-
'-DBUILD_SHARED_LIBS=OFF']
499-
500-
if '-apple-macosx' in args.build_target:
501-
yams_cmake_flags.append('-DCMAKE_OSX_DEPLOYMENT_TARGET=%s' % macos_deployment_target)
502-
yams_cmake_flags.append('-DCMAKE_C_FLAGS=-target %s' % target)
503-
else:
504-
yams_cmake_flags.append('-DCMAKE_C_FLAGS=-fPIC -target %s' % target)
505-
if args.foundation_build_dir:
506-
yams_cmake_flags.append(get_foundation_cmake_arg(args))
507-
yams_swift_flags = swift_flags[:]
508-
cmake_build(args, swiftc_exec, yams_cmake_flags, yams_swift_flags,
509-
yams_source_dir, yams_build_dir)
510-
511489
def build_argument_parser_using_cmake(args, target, swiftc_exec, build_dir, base_cmake_flags, swift_flags):
512490
print('Building Swift Driver dependency: Argument Parser')
513491
parser_source_dir = os.path.join(os.path.dirname(args.package_path), 'swift-argument-parser')
@@ -529,7 +507,6 @@ def build_swift_driver_using_cmake(args, target, swiftc_exec, build_dir, base_cm
529507
flags = [
530508
'-DLLBuild_DIR=' + os.path.join(os.path.join(dependencies_dir, 'llbuild'), 'cmake/modules'),
531509
'-DTSC_DIR=' + os.path.join(os.path.join(dependencies_dir, 'swift-tools-support-core'), 'cmake/modules'),
532-
'-DYams_DIR=' + os.path.join(os.path.join(dependencies_dir, 'yams'), 'cmake/modules'),
533510
'-DArgumentParser_DIR=' + os.path.join(os.path.join(dependencies_dir, 'swift-argument-parser'), 'cmake/modules')]
534511
driver_cmake_flags = base_cmake_flags + flags
535512
cmake_build(args, swiftc_exec, driver_cmake_flags, driver_swift_flags,

0 commit comments

Comments
 (0)
Please sign in to comment.