Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest writing does not use a preferred path separator #5475

Open
compnerd opened this issue May 7, 2022 · 0 comments
Open

Manifest writing does not use a preferred path separator #5475

compnerd opened this issue May 7, 2022 · 0 comments
Labels
windows

Comments

@compnerd
Copy link
Member

compnerd commented May 7, 2022

The manifest writer seems to use the UNIX path separator unconditionally, which is appended to the file path to indicate a directory rather than the platform's preferred path separator.
compnerd added a commit to compnerd/swift-package-manager that referenced this issue May 8, 2022
@compnerd
Tests: adjust LLBuildManifestTests expectations for Windows
47f9eb3 
This adjusts the expectations to allow Windows to be supported as well
with the use of the paths more thoroughly.  This identified an issue in
the path handling in the manifest generation (tracked as swiftlang#5475).
@compnerd compnerd mentioned this issue May 8, 2022
Merged
tomerd pushed a commit that referenced this issue May 9, 2022
@compnerd
Tests: adjust LLBuildManifestTests expectations for Windows (#5477)
cd93125 
This adjusts the expectations to allow Windows to be supported as well
with the use of the paths more thoroughly.  This identified an issue in
the path handling in the manifest generation (tracked as #5475).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@compnerd