Skip to content

[bug]: post-icon incorrect URL #5093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alizedebray opened this issue Mar 21, 2025 · 0 comments · May be fixed by #5109 or #5110
Open

[bug]: post-icon incorrect URL #5093

alizedebray opened this issue Mar 21, 2025 · 0 comments · May be fixed by #5109 or #5110
Assignees
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request This is a request from a contributor outside of the core team. v8 v9

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Mar 21, 2025

Describe the bug
The post-icon URL is not correct when used with a <base href="/" />.
The URL is then "http://my-domain.ch//2000.svg".

Expected behavior
The URL should be "http://my-domain.ch/2000.svg".

In general, icon URLs should be constructed as:
current domain + base[href] + meta[name="design-system-settings"][data-post-icon-base]) (overridden by a potential base property set on the component)
If the base[href] is not relative, it is instead of current domain + base[href].
If the meta[name="design-system-settings"][data-post-icon-base]) (or the base prop) is not relative, it is used as is.

@alizedebray alizedebray added the 🐞 bug Something isn't working label Mar 21, 2025
@alizedebray alizedebray added the 📦 components Related to the @swisspost/design-system-components package label Mar 21, 2025
@gfellerph gfellerph added the v8 label Mar 25, 2025
@gfellerph gfellerph added this to the Long Term Support v8 milestone Mar 25, 2025
@gfellerph gfellerph added v9 request This is a request from a contributor outside of the core team. labels Mar 25, 2025
@gfellerph gfellerph moved this from 👀 Triage to 🆗 Ready in Design System Production Board Mar 25, 2025
@schaertim schaertim self-assigned this Mar 26, 2025
@schaertim schaertim moved this from 🆗 Ready to 💻 In Progress in Design System Production Board Mar 27, 2025
@schaertim schaertim moved this from 💻 In Progress to 🧐 In Review in Design System Production Board Apr 2, 2025
@schaertim schaertim moved this from 🧐 In Review to 💻 In Progress in Design System Production Board Apr 2, 2025
@schaertim schaertim moved this from 💻 In Progress to 🧐 In Review in Design System Production Board Apr 8, 2025
@schaertim schaertim moved this from 🧐 In Review to 💻 In Progress in Design System Production Board Apr 8, 2025
@schaertim schaertim moved this from 💻 In Progress to 🧐 In Review in Design System Production Board Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package request This is a request from a contributor outside of the core team. v8 v9
Projects
Status: 🧐 In Review
3 participants