Skip to content

Refactor not-defined selector generator #5164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oliverschuerch opened this issue Apr 1, 2025 · 1 comment · May be fixed by #5165
Open

Refactor not-defined selector generator #5164

oliverschuerch opened this issue Apr 1, 2025 · 1 comment · May be fixed by #5165
Assignees
@oliverschuerch
Labels
🍀 decision Marks conversations where a decision has been made 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Maintenance IV

Comments

@oliverschuerch
Copy link
Contributor

The selectors currently get generated by parsing the components/src/index.ts file.
With the next stencil update this file will not export every component by its own, but export them all with one single statement.
Therefore, we need to change the way we generate the not-defined selector.
We decided to do so, by reading the components/src/components folders and using their names as tag selectors.
@oliverschuerch oliverschuerch added the 📦 styles Related to the @swisspost/design-system-styles package label Apr 1, 2025
@oliverschuerch oliverschuerch added this to the Maintenance IV milestone Apr 1, 2025
@oliverschuerch oliverschuerch self-assigned this Apr 1, 2025
@oliverschuerch oliverschuerch moved this from 👀 Triage to 🆗 Ready in Design System Production Board Apr 1, 2025
@oliverschuerch oliverschuerch linked a pull request Apr 1, 2025 that will close this issue
refactor(styles): generate not-defined selectors by using the components/src/components/ subfolder names #5165
Open
@oliverschuerch oliverschuerch moved this from 🆗 Ready to 🧐 In Review in Design System Production Board Apr 1, 2025
@oliverschuerch oliverschuerch added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Apr 10, 2025
@gfellerph
Copy link
Member

Image

Decision: move to components

@gfellerph gfellerph added 🍀 decision Marks conversations where a decision has been made and removed needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers labels Apr 10, 2025
@oliverschuerch oliverschuerch moved this from 🧐 In Review to 💻 In Progress in Design System Production Board Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverschuerch oliverschuerch

Labels
🍀 decision Marks conversations where a decision has been made 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 💻 In Progress
Milestone
Maintenance IV
2 participants
@gfellerph @oliverschuerch