Skip to content

Commit 39123f8

Browse files
committed
lsp: Stop suppressing TimeoutError
1 parent 895d637 commit 39123f8

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

lib/esbonio/tests/e2e/conftest.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,4 @@ async def client(lsp_client: LanguageClient, uri_for, tmp_path_factory):
8686
yield
8787

8888
# Teardown
89-
try:
90-
await asyncio.wait_for(lsp_client.shutdown_session(), timeout=2.0)
91-
except (asyncio.TimeoutError, TimeoutError):
92-
# HACK: Working around openlawlibrary/pygls#433
93-
print("Gave up waiting for process to exit")
89+
await asyncio.wait_for(lsp_client.shutdown_session(), timeout=2.0)

lib/esbonio/tests/e2e/test_e2e_diagnostics.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,7 @@ async def pub_client(lsp_client: LanguageClient, uri_for, tmp_path_factory):
172172
yield
173173

174174
# Teardown
175-
try:
176-
await asyncio.wait_for(lsp_client.shutdown_session(), timeout=2.0)
177-
except (asyncio.TimeoutError, TimeoutError):
178-
# HACK: Working around openlawlibrary/pygls#433
179-
print("Gave up waiting for process to exit")
175+
await asyncio.wait_for(lsp_client.shutdown_session(), timeout=2.0)
180176

181177

182178
@pytest.mark.asyncio(loop_scope="module")

lib/esbonio/tests/server/conftest.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,4 @@ async def client(request, uri_for, lsp_client: LanguageClient):
4141
yield
4242

4343
# Teardown
44-
try:
45-
await asyncio.wait_for(lsp_client.shutdown_session(), timeout=2.0)
46-
except (asyncio.TimeoutError, TimeoutError):
47-
# HACK: Working around openlawlibrary/pygls#433
48-
print("Gave up waiting for process to exit")
44+
await asyncio.wait_for(lsp_client.shutdown_session(), timeout=2.0)

0 commit comments

Comments
 (0)