Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server should build project before generating preview, if necessary #783

Closed
alcarney opened this issue Apr 23, 2024 · 0 comments · Fixed by #793
Closed

Server should build project before generating preview, if necessary #783

alcarney opened this issue Apr 23, 2024 · 0 comments · Fixed by #793
Labels
bug Something isn't working lsp Issues that relate to the language server
Milestone
1.0

Comments

@alcarney
Copy link
Member

Expected behavior

This used to be the case in 0.91.0 of the extension, then it was removed because of #660 and similar issues.
Now however, it should be safe to bring this back and is a common point of friction (#763, #778, #699 (comment))

Actual behavior

The server automatically trigger a Sphinx build of a project (if necessary) before opening the preview.

Log output

No response

(Optional) Settings from conf.py

No response
@alcarney alcarney added bug Something isn't working lsp Issues that relate to the language server labels Apr 23, 2024
@alcarney alcarney added this to the 1.0 milestone Apr 23, 2024
@alcarney alcarney mentioned this issue Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lsp Issues that relate to the language server
Projects
Esbonio
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Preview improvements alcarney/esbonio
1 participant
@alcarney