-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test #859
Labels
bug
Something isn't working
help wanted
Extra attention is needed
lsp
Issues that relate to the language server
os:windows
Issues only found on Windows
Milestone
Comments
alcarney
added
bug
Something isn't working
lsp
Issues that relate to the language server
labels
Jul 21, 2024
alcarney
added a commit
to alcarney/esbonio
that referenced
this issue
Sep 29, 2024
When `manager.get_client` is called many times in quick succession (such as on server restart with N files open) this can fool the `SphinxManager` into creating multiple client instances for a given configuration scope. By storing a ``None`` at the relevant scope we allow the SphinxManager to detect that the scope has already been handled, preventing the spawning of duplicated client instances. This should, finally, fix the flaky test issue (swyddfa#859)
While this commit appears to have resolved the original cause of flaky-ness, two new sources of flaky-ness appear to have shown themselves...
|
|
alcarney
added a commit
that referenced
this issue
Sep 29, 2024
When `manager.get_client` is called many times in quick succession (such as on server restart with N files open) this can fool the `SphinxManager` into creating multiple client instances for a given configuration scope. By storing a ``None`` at the relevant scope we allow the SphinxManager to detect that the scope has already been handled, preventing the spawning of duplicated client instances. This should, finally, fix the flaky test issue (#859)
alcarney
added
help wanted
Extra attention is needed
os:windows
Issues only found on Windows
labels
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
help wanted
Extra attention is needed
lsp
Issues that relate to the language server
os:windows
Issues only found on Windows
Expected behavior
The test to pass reliably
Actual behavior
The mechanism that should prevent duplicate clients from being spawned fails and leads to errors
Log output
(Optional) Settings from conf.py
No response
The text was updated successfully, but these errors were encountered: