Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler parses comments #88

Open
charlesUnixPro opened this issue Aug 21, 2020 · 2 comments
Open

Assembler parses comments #88

charlesUnixPro opened this issue Aug 21, 2020 · 2 comments
Assignees
Labels

Comments

@charlesUnixPro
Copy link

$ cat foo.asm
; this is a comment with an embedded apostrophe (')
; this is a comment with two embedded apostrophes ('')
; this is a comment with an embedded quote (")
; this is a comment with two embedded quotes ("")


$ ../assembler/asm foo.asm
foo.asm:1:50: warning: missing terminating ' character
 ; this is a comment with an embedded apostrophe (')
                                              ^
foo.asm:3:45: warning: missing terminating " character
 ; this is a comment with an embedded quote (")
                                             ^
qasm2rom: 0 ROM lines written.
@sy2002
Copy link
Owner

sy2002 commented Aug 21, 2020

@charlesUnixPro Thank you Charles. This is a known issue. We worked around in past by instead of writing

; this is the register's value

we wrote

; this is the value of the register

Admitably not great 😈

I assigned this one to Bernd - maybe he comes up with some ideas of how to fix that in V1.7; but it also might be that this one stays until we implement issue #20 "Make native assembler independent from external preprocessor"

@bernd-ulmann
Copy link
Collaborator

Mirko is right, this error is caused by my sloppy way of using the C-preprocessor for the assembler, and the C-preprocessor does not understand our ";" comment delimiter.

This problem will be solved when we have our own (simple) preprocessor for the assembler that does not rely on the C-preprocessor, so I fear it won't be fixed prior to 1.7.

@sy2002 sy2002 added V2.0 and removed V1.7 labels Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants