Highscores Not Supported filter shows tables with high scores

[gorgatron1]

Describe the bug

Highscores Not Supported filter shows tables with high scores

To Reproduce

See screenshot:

It looks like the "Text" high scores are incorrectly marked as not supported (though clearly not all Text games):

Here is an nvram one that has a legit high score (for this rom anyway):

and a VPReg:

Expected behavior

Highscores Not Supported filter should only be tables with no high scores.

[syd711]

I've tested 2 of the 3 tables and they were filtered correctly. Are there any "Exceptions" in the logs when the filtering is applied?

[gorgatron1]

vpin-studio-logs.zip

Here are my logs -- there are some score parsing errors (and I would be happy to send you the files if I could figure out which ones they are!)

For example Aliens using sorcr_l1 shows in the filtered unusable but I can see the scores and you can see the activity related to it:

29-12 14:41:35.949 INFO  [/api/v1/games/scanscore/454]d.m.v.r.u.SystemCommandExecutor - System Command: D:\vpx\VPin-Studio\.\resources\pinemhi> cmd.exe /c PINemHi.exe sorcr_l1.nv
29-12 14:41:36.050 INFO  [/api/v1/games/scanscore/454]d.m.v.s.h.HighscoreService - Skipped highscore change event for "sorcr_l1" because there was no score change for rom 'Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0' detected.
29-12 14:41:36.079 INFO  [/api/v1/games/save]d.m.v.s.g.GameService - Saved "Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0"
29-12 14:41:36.367 INFO  [FX Card Generator Thread for Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0]d.m.v.s.u.ImageUtil - Cropping image from 2560x1440 to 2560x1440
29-12 14:41:36.727 INFO  [FX Card Generator Thread for Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0]d.m.v.s.u.ImageUtil - Writing D:\vpx\VPin-Studio\.\resources\media-cropped\454_background.png took 245ms.
29-12 14:41:36.727 INFO  [FX Card Generator Thread for Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0]d.m.v.s.s.DefaultPictureService - Written cropped default background for sorcr_l1
29-12 14:41:37.585 INFO  [FX Card Generator Thread for Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0]d.m.v.s.u.ImageUtil - Writing D:\vpx\VPin-Studio\.\resources\highscore-card-sample.png took 166ms.

Is this unusable state something that got set at one point and never got reset? Can I force a rescan of the high score somehow?

If you add a filename in the log regarding these:

29-12 14:41:37.825 INFO  [/api/v1/games/scorehistory/454]d.m.v.s.h.p.ScoreListFactory - Failed to parse highscore string '??   0', ignoring segment '??   0'

I will cut another issue and include the files.

[syd711]

29-12 14:41:36.050 INFO [/api/v1/games/scanscore/454]d.m.v.s.h.HighscoreService - Skipped highscore change event for "sorcr_l1" because there was no score change for rom 'Alien Nostromo 2 (Original 2024) Bombaj344 1.0.0' detected.

Messages like these are coming form an actual refresh. It means the score has been re-read, but no notifications are send, because nothing has changed.

Can I force a rescan of the high score somehow?

Yes, with the result above. The refresh button in the highscore section does trigger a re-scan.

This "ScoreListFactory" message is interesting though, I'll improve the message so that the source can be identified.

[gorgatron1]

Yes, with the result above. The refresh button in the highscore section does trigger a re-scan.

I tried that on a couple of tables with no apparent effect -- it had read the scores before and it still showed them. It didn't clear the "not supported" state.

Anything else I can do to narrow this down?

To be clear: this doesn't seem to have any effect on the operation -- scores work for these tables. It just shows (incorrectly I think) that they are unsupported via the filtering.

[syd711]

I switched to my PinballX environment where I can reproduce this. I'll get back with the details/fix.

Ok, that was something different. But I checked the validation again. For the tables that seem valid, you can check what the issue is by checking the score settings of the table. The icon/tooltip should give a hint.

[syd711]

Could you provide any examples, similar to the screenshot above?
These hints should show why the table is part of the filter.

[gorgatron1]

Here is an nvram one:

Here is a text -- it has scores in the high scores section, but shows an error in the tooltip:

Not sure why it didn't take the scanned value (and also the apply button is disabled). If I manually select it then it shows a green check but still shows in the not working filter:

Here is a VPReg table that has a valid score but the scores panel shows that it is missing a VPReg entry:

[gorgatron1]

All of those tables seem to have working high scores 🤷

[syd711]

Thanks, this is already helping a lot. I assume we improved the detection of highscores but did not adapt this validation accordingly. This narraws it down.